Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add action to enforce semantic-pr titles#6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomainfrompr6075
Nov 24, 2022
Merged

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedNov 24, 2022•
edited
Loading

PR Checklist

Overview

I've seen a few PRs recently that haven't had the correct titles.
I accidentally merged one that was missing the colon!

This PR adds an action that will validate the PR titles match the semantic commit spec using this action:
https://github.com/amannn/action-semantic-pull-request

JoshuaKGoldberg reacted with thumbs up emoji
I've seen a few PRs recently that haven't had the correct titles.I accidentally merged one that was missing the colon!This PR adds an action that will validate the PR titles match the semantic commit spec using this action:https://github.com/amannn/action-semantic-pull-request
@nx-cloud
Copy link

nx-cloudbot commentedNov 24, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit2b369ce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 24, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2b369ce
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/637eb6fabc412f0008509d5f
😎 Deploy Previewhttps://deploy-preview-6075--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@bradzacherbradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs labelNov 24, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool!

The "subject" must start with a lower-case letter and must not
end with a full-stop.
For PRs that add or change ESLint-plugin rules, you should begin
the title with "[rule-name] "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It'd be nice if this was enforceable too.

bradzacher reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yeah it's just hard cos if you're making non-rule-specific changes you don't want to add it - so it's hard to properly enforce.

JoshuaKGoldberg reacted with thumbs up emoji
@bradzacherbradzacher merged commit53671d3 intomainNov 24, 2022
@bradzacherbradzacher deleted the pr6075 branchNovember 24, 2022 02:57
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
repo maintenancethings to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: setup a GH action to help validate and educate PR title
2 participants
@bradzacher@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp