Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: use no-restricted-syntax to enforce created options in rules#6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedNov 23, 2022•
edited
Loading

PR Checklist

Overview

Usesno-restricted-syntax to enforce always usingcreate's second parameter, rather thancontext.options.

omril1 reacted with heart emojiomril1 reacted with rocket emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedNov 23, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit790a565. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

omril1
omril1 previously approved these changesNov 23, 2022
@bradzacherbradzacher deleted the branchtypescript-eslint:mainNovember 24, 2022 00:20
@bradzacherbradzacher changed the base branch fromkeyword-spacing-options tomainNovember 24, 2022 00:25
@bradzacherbradzacher dismissedomril1’sstale reviewNovember 24, 2022 00:25

The base branch was changed.

@bradzacher
Copy link
Member

man GH did something fucky there. The PR targetted the branch in#6073. When I closed the PR the branch was deleted so it closed this PR and i had to undelete the branch to be able to change the PR target.

that was weird

bradzacher
bradzacher previously approved these changesNov 24, 2022
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewNovember 24, 2022 02:39
@netlify
Copy link

netlifybot commentedNov 24, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit790a565
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/637fc5863b4f74000a93ace3
😎 Deploy Previewhttps://deploy-preview-6074--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlechore: add internal lint rule to always prefer created optionschore: use no-restricted-syntax to enforce created options in rulesNov 24, 2022
@JoshuaKGoldberg
Copy link
MemberAuthor

Huh, that is weird. It used to retarget the PR nicely :(

@JoshuaKGoldbergJoshuaKGoldberg merged commitee62b0b intotypescript-eslint:mainNov 24, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the lint-always-create-options branchNovember 24, 2022 19:39
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

@omril1omril1omril1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Add lint rule to prefer create's second parameter over context.options
3 participants
@JoshuaKGoldberg@bradzacher@omril1
[8]ページ先頭
©2009-2025 Movatter.jp