Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [keyword-spacing] prevent crash on no options#6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomainfromkeyword-spacing-options
Nov 24, 2022

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Sources theafter option from the second parameter tocreate instead ofcontext.options. Turns out the latter is the raw user-provided options beforedefaultOptions are applied.

omril1 and vuki656 reacted with rocket emoji
@nx-cloud
Copy link

nx-cloudbot commentedNov 23, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit6e7ade5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 23, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit6e7ade5
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/637e3f71ccf1f50008d17c2a
😎 Deploy Previewhttps://deploy-preview-6073--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewNovember 23, 2022 15:42
@codecov
Copy link

codecovbot commentedNov 23, 2022
edited
Loading

Codecov Report

Merging#6073 (6e7ade5) intomain (90d2ce0) willnot change coverage.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #6073   +/-   ##=======================================  Coverage   91.28%   91.28%           =======================================  Files         366      366             Lines       12353    12353             Branches     3612     3612           =======================================  Hits        11276    11276             Misses        768      768             Partials      309      309
FlagCoverage Δ
unittest91.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ackages/eslint-plugin/src/rules/keyword-spacing.ts100.00% <100.00%> (ø)

@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamNovember 23, 2022 19:44
@bradzacherbradzacher added the bugSomething isn't working labelNov 24, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

elon_test_in_production

lvjiaxuan reacted with laugh emoji
@bradzacherbradzacher merged commit1f19998 intomainNov 24, 2022
@bradzacherbradzacher deleted the keyword-spacing-options branchNovember 24, 2022 00:20
@bradzacherbradzacher restored the keyword-spacing-options branchNovember 24, 2022 00:23
@bradzacherbradzacher deleted the keyword-spacing-options branchNovember 24, 2022 00:23
@bradzacherbradzacher restored the keyword-spacing-options branchNovember 24, 2022 00:25
@bradzacherbradzacher deleted the keyword-spacing-options branchNovember 24, 2022 00:25
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

+1 more reviewer

@omril1omril1omril1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: @typescript-eslint/keyword-spacing crashes

4 participants

@JoshuaKGoldberg@bradzacher@omril1

[8]ページ先頭

©2009-2025 Movatter.jp