typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

chore: removed eslint@6 fallbacks for rule messages, and a snapshot#6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v6fromJoshuaKGoldberg:more-eslint-removals

Nov 19, 2022

Merged

chore: removed eslint@6 fallbacks for rule messages, and a snapshot#6041

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v6fromJoshuaKGoldberg:more-eslint-removals

Nov 19, 2022

Conversation

Copy link

Member

JoshuaKGoldberg commentedNov 19, 2022•
edited
Loading

Overview

I stumbled onto some more references to ESLint v6 in the codebase. I hadn't known about them. 🔪

cc@bmish from#5968 ->#5972

Copy link

nx-cloudbot commentedNov 19, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitca41067. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedNov 19, 2022

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

JoshuaKGoldberg changed the base branch frommain tov6

November 19, 2022 06:35

Copy link

netlifybot commentedNov 19, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ef4465f`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6378791c9ba9640009badd16
😎 Deploy Preview	https://deploy-preview-6041--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

chore: removed eslint@6 fallbacks for rule messages, and a snapshot

ca41067

JoshuaKGoldberg force-pushed themore-eslint-removals branch fromef4465f toca41067Compare

November 19, 2022 06:35

JoshuaKGoldberg marked this pull request as ready for review

November 19, 2022 06:38

Copy link

codecovbot commentedNov 19, 2022•
edited
Loading

Codecov Report

Merging#6041 (ca41067) intov6 (b8c65fd) willincrease coverage by0.02%.
The diff coverage is0.00%.

Additional details and impacted files

@@            Coverage Diff             @@##               v6    #6041      +/-   ##==========================================+ Coverage   91.69%   91.72%   +0.02%==========================================  Files         356      356                Lines       12023    12018       -5       Branches     3524     3519       -5     ==========================================- Hits        11024    11023       -1  Misses        701      701+ Partials      298      294       -4

Flag	Coverage Δ
unittest	`91.72% <0.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ackages/eslint-plugin/src/rules/no-invalid-this.ts	`83.33% <ø> (+3.33%)`	⬆️
...s/eslint-plugin/src/rules/no-unused-expressions.ts	`94.44% <ø> (+4.97%)`	⬆️
.../eslint-plugin/src/rules/no-useless-constructor.ts	`94.73% <0.00%> (-0.27%)`	⬇️
packages/eslint-plugin/src/rules/quotes.ts	`94.11% <ø> (+5.22%)`	⬆️
packages/eslint-plugin/src/rules/semi.ts	`100.00% <ø> (+7.14%)`	⬆️