Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): [array-type] --fix flag removes parentheses from type#5997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1982,6 +1982,61 @@ class Foo<T = Bar[][]> extends Bar<T, T[]> implements Baz<T[]> { | ||
| } | ||
| `, | ||
| ); | ||
| testOutput( | ||
| 'array', | ||
| ` | ||
| interface WorkingArray { | ||
| outerProperty: Array< | ||
| { innerPropertyOne: string } & { innerPropertyTwo: string } | ||
| >; | ||
| } | ||
| interface BrokenArray { | ||
| outerProperty: Array< | ||
| ({ innerPropertyOne: string } & { innerPropertyTwo: string }) | ||
| >; | ||
| } | ||
| `, | ||
| ` | ||
| interface WorkingArray { | ||
| outerProperty: ({ innerPropertyOne: string } & { innerPropertyTwo: string })[]; | ||
| } | ||
| interface BrokenArray { | ||
| outerProperty: ({ innerPropertyOne: string } & { innerPropertyTwo: string })[]; | ||
| } | ||
| `, | ||
| ); | ||
| testOutput( | ||
| 'array', | ||
| ` | ||
| type WorkingArray = { | ||
| outerProperty: Array< | ||
| { innerPropertyOne: string } & { innerPropertyTwo: string } | ||
| >; | ||
| } | ||
| type BrokenArray = { | ||
| outerProperty: Array< | ||
| ({ innerPropertyOne: string } & { innerPropertyTwo: string }) | ||
| >; | ||
| } | ||
| `, | ||
| ` | ||
| type WorkingArray = { | ||
| outerProperty: ({ innerPropertyOne: string } & { innerPropertyTwo: string })[]; | ||
| } | ||
| type BrokenArray = { | ||
| outerProperty: ({ innerPropertyOne: string } & { innerPropertyTwo: string })[]; | ||
| } | ||
| `, | ||
| ); | ||
Comment on lines +2010 to +2034 Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. This test case looks identical to the one above? ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. @Josh-Cena One is with type and the other one is with interface, I wanted to be sure it doesn't affect the code different on either keyword. I can modify it a bit if you like@Josh-Cena Maybe something like | ||
| testOutput( | ||
| 'array', | ||
| 'const a: Array<(string|number)>;', | ||
| 'const a: (string|number)[];', | ||
| ); | ||
| testOutput( | ||
| 'array-simple', | ||
| 'let xx: Array<Array<number>> = [[1, 2], [3]];', | ||