CI is running/has finished running commands for commit22be168. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedNov 15, 2022

Thanks for the PR,@omril1!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 15, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`22be168`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6373d648e705d00008af7c6e
😎 Deploy Preview	https://deploy-preview-5992--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Merge branch 'main' into fix/issue5991-fix-prefer-optional-chain-Bina…

126404b

…ryExpression-in-negated-or

JoshuaKGoldberg requested changes

Nov 15, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great in general, thanks for sending this in so quickly! Just requesting changes for a little code simplification please. 🎉

packages/eslint-plugin/src/rules/prefer-optional-chain.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg changed the title~~fix/issue5991-fix-prefer-optional-chain-BinaryExpression-in-negated-or~~fix(eslint-plugin): [prefer-optional-chain] handle binary expressions in negated or

Nov 15, 2022

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 15, 2022

Omri Luzon added2 commits

November 15, 2022 20:10

CR

a9f1a05

Merge branch 'main' into fix/issue5991-fix-prefer-optional-chain-Bina…

22be168

…ryExpression-in-negated-or

omril1 requested a review fromJoshuaKGoldberg

November 15, 2022 20:22

JoshuaKGoldberg approved these changes

Nov 16, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks!

JoshuaKGoldberg merged commit2778ff0 intotypescript-eslint:main

Nov 16, 2022

omril1 deleted the fix/issue5991-fix-prefer-optional-chain-BinaryExpression-in-negated-or branch

November 16, 2022 04:02

Copy link

RobYed commentedNov 17, 2022

@omril1 Thanks for the quick fix!

@JoshuaKGoldberg Do you have an estimate of when this fix will be released? My project is also affected by this issue, thus looking forward to the next release.