Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): [prefer-nullish-coalescing] explicit notice for strictNullChecks#5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

cparros
Copy link
Contributor

@cparroscparros commentedNov 14, 2022•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

This PR adds a line to theprefer-nullish-coalescing docs letting the reader know the rule will not work as intended ifstrict-null-checks is not enabled.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@cparros!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedNov 14, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit1fd102e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedNov 14, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit1fd102e
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63726447def2690008ed0c84
😎 Deploy Previewhttps://deploy-preview-5988--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlechore(website): [prefer-nullish-coalescing] explicit notice for stric…chore(website): [prefer-nullish-coalescing] explicit notice for strictNullChecksNov 14, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯, thanks for this@cparros!

@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)November 14, 2022 15:52
@JoshuaKGoldbergJoshuaKGoldberg merged commitceddb34 intotypescript-eslint:mainNov 14, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [prefer-nullish-coalescing] doesn't work withstrictNullChecks: false.
2 participants
@cparros@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp