Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: enableeslint-plugin/require-meta-docs-description rule#5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

bmish
Copy link
Contributor

@bmishbmish commentedNov 11, 2022•
edited
Loading

PR Checklist

Overview

Enable this optional rule for rule source files internally:https://github.com/eslint-community/eslint-plugin-eslint-plugin/blob/main/docs/rules/require-meta-docs-description.md

Same change in ESLint recently:eslint/eslint#16529

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bmish!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedNov 11, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf192f21. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedNov 11, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf192f21
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/636d9d632559600008cf37d9
😎 Deploy Previewhttps://deploy-preview-5969--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@bradzacherbradzacher changed the titleEnableeslint-plugin/require-meta-docs-description rulechore: enableeslint-plugin/require-meta-docs-description ruleNov 11, 2022
@bmishbmishforce-pushed theeslint-plugin-require-meta-docs-description branch from1893658 tof192f21CompareNovember 11, 2022 00:54
@@ -257,6 +257,11 @@ module.exports = {
'./packages/eslint-plugin/src/rules/**/*.ts',
],
rules: {
'eslint-plugin/require-meta-docs-description': [
'error',
{ pattern: '^(Enforce|Require|Disallow) .+[^. ]$' },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, TIL about this one. Eventually maybe we'll even narow this list down to two 😄

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks as always@bmish! 🙌

@JoshuaKGoldbergJoshuaKGoldberg merged commit0e1e71d intotypescript-eslint:mainNov 11, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bmish@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp