Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin)!: Move opinionated rules from 'eslint-recommended' to 'recommended'#595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

borekb
Copy link
Contributor

@borekbborekb commentedJun 6, 2019•
edited by bradzacher
Loading

BREAKING CHANGE

Resolves#592.

CvX reacted with thumbs up emoji
BREAKING CHANGE: both 'eslint-recommended' and 'recommended' have changed.
@bradzacherbradzacher added breaking changeThis change will require a new major version to be released recommended-rulesDiscussion about recommended rule sets labelsJun 6, 2019
@bradzacherbradzacher mentioned this pull requestJun 28, 2019
14 tasks
@bradzacherbradzacher added this to the2.0.0 milestoneJun 28, 2019
@bradzacherbradzacher changed the titleMove opinionated rules from 'eslint-recommended' to 'recommended'feat(eslint-plugin)!: Move opinionated rules from 'eslint-recommended' to 'recommended'Jul 21, 2019
Copy link
Member

@JamesHenryJamesHenry left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable, thanks

@JamesHenryJamesHenry added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJul 24, 2019
@JamesHenryJamesHenry merged commit4893aec intotypescript-eslint:masterJul 24, 2019
bradzacher added a commit that referenced this pull requestJul 29, 2019
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergebreaking changeThis change will require a new major version to be releasedrecommended-rulesDiscussion about recommended rule sets
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Move opinionated rules from 'eslint-recommended' to 'recommended'?
3 participants
@borekb@JamesHenry@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp