Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(naming-conventions): Alphabetizing inline lists#5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromvaishnav-mk:patch-1
Nov 12, 2022
Merged

docs(naming-conventions): Alphabetizing inline lists#5940

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromvaishnav-mk:patch-1
Nov 12, 2022

Conversation

vaishnav-mk
Copy link
Contributor

@vaishnav-mkvaishnav-mk commentedNov 8, 2022•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

This pr alphabetizes inline lists for naming convention rules

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@vaishnav-mk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedNov 8, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4335415. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedNov 8, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4335415
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/636faf92cbb3f30008594212
😎 Deploy Previewhttps://deploy-preview-5940--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a great start, thanks@vaishnav-mk! 🚀

I'll note that I'd hoped for"both actual * lists and comma-sorted inline ones" in the issue, so I'll keep it open, and added#5934 (comment). If you want to send a followup PR that sorts list items too, that'd be great!

@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)November 12, 2022 14:42
@JoshuaKGoldbergJoshuaKGoldberg merged commit91d71bc intotypescript-eslint:mainNov 12, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vaishnav-mk@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp