Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin)!: remove "isTypescriptFile".#594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzukisosukesuzuki commentedJun 6, 2019•
edited by bradzacher
Loading

BREAKING CHANGE

Resolve#524

Remove isTypescriptFile to make some typescript-eslint rules compate with files are not .ts or .tsx(e.g. .vue).

@codecov
Copy link

codecovbot commentedJun 6, 2019•
edited
Loading

Codecov Report

Merging#594 intomaster willincrease coverage by0.03%.
The diff coverage is80%.

@@            Coverage Diff             @@##           master     #594      +/-   ##==========================================+ Coverage   94.41%   94.45%   +0.03%==========================================  Files         113      113                Lines        4711     4705       -6       Branches     1293     1288       -5     ==========================================- Hits         4448     4444       -4  Misses        150      150+ Partials      113      111       -2
Impacted FilesCoverage Δ
packages/eslint-plugin/src/util/misc.ts84.21% <ø> (+3.25%)⬆️
...-plugin/src/rules/explicit-function-return-type.ts100% <100%> (ø)⬆️
...-plugin/src/rules/explicit-member-accessibility.ts89.58% <78.94%> (+1.34%)⬆️

@bradzacherbradzacher added the breaking changeThis change will require a new major version to be released labelJun 6, 2019
@bradzacherbradzacher mentioned this pull requestJun 6, 2019
14 tasks
@sosukesuzuki
Copy link
ContributorAuthor

@bradzacher Sorry, I considered to pass the CodeCov, but I did not know what to do. Should probably I add some tests?

bradzacher
bradzacher previously approved these changesJun 10, 2019
@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJun 10, 2019
JamesHenry
JamesHenry previously requested changesJun 20, 2019
@JamesHenry
Copy link
Member

Just the one update, then we can merge this. Thanks@sosukesuzuki!

bradzacher reacted with thumbs up emojisosukesuzuki reacted with heart emoji

@bradzacherbradzacher changed the titlefix(eslint-plugin): remove "isTypescriptFile".fix(eslint-plugin)!: remove "isTypescriptFile".Jul 21, 2019
@JamesHenryJamesHenry merged commit4933ade intotypescript-eslint:masterJul 21, 2019
@sosukesuzukisosukesuzuki deleted the remove-istypescriptfile branchAugust 12, 2019 04:28
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergebreaking changeThis change will require a new major version to be releasedbugSomething isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Make typescript-eslint rules compatible with .vue files
3 participants
@sosukesuzuki@JamesHenry@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp