Doing this ahead of#5573 to improve reviewability.
This PR marks all of our dependency requirements for tests back to TSv4.0.8 - I didn't go back further because#5915 bumps the minimum past that anyways

tests: add dependency constraints to eslint-plugin tests

4598ca8

bradzacher added the testsanything to do with testing label

Nov 2, 2022

Copy link

Contributor

typescript-eslintbot commentedNov 2, 2022

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloudbot commentedNov 2, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9396b38. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedNov 2, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`9396b38`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63756ed625114a0009371037
😎 Deploy Preview	https://deploy-preview-5916--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JoshuaKGoldberg previously approved these changes

Nov 13, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🔥

packages/eslint-plugin/tests/rules/non-nullable-type-assertion-style.test.ts OutdatedShow resolvedHide resolved

Update packages/eslint-plugin/tests/rules/non-nullable-type-assertion…

b4dd439

…-style.test.ts

JoshuaKGoldberg dismissed theirstale review viab4dd439

November 13, 2022 23:30

JoshuaKGoldberg previously approved these changes

Nov 13, 2022

View reviewed changes

Merge branch 'main'

27eb35c

JoshuaKGoldberg dismissed theirstale review via27eb35c

November 13, 2022 23:32

JoshuaKGoldberg previously approved these changes

Nov 13, 2022

View reviewed changes

JoshuaKGoldbergenabled auto-merge (squash)

November 13, 2022 23:34

JoshuaKGoldbergdisabled auto-merge

November 14, 2022 00:12

yarn format

ef2105a

JoshuaKGoldberg dismissed theirstale review viaef2105a

November 14, 2022 00:13

JoshuaKGoldberg added2 commits

November 13, 2022 19:13

Merge branch 'main' into add-dep-constraints-to-rule-tests

e6ea324

Fix lint issues with formatting

3965014

Copy link

Member

JoshuaKGoldberg commentedNov 14, 2022•
edited
Loading

~~I see some new test failures after my merge - will try to fix soon...~~ ✅

(they were existing, somewhat)

JoshuaKGoldberg added2 commits

November 14, 2022 17:27

Remove dependencyConstraints from test cases too

6bee109

Update snapshots

7bb7eee

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 15, 2022

JoshuaKGoldberg requested changes

Nov 15, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

non-nullable-type-assertion-style has a failure - otherwise this looks good to go!

fix failing test

d81c4e4

bradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 16, 2022

bradzacher added2 commits

November 16, 2022 18:22

revert rule tester change

56bd530

fix(typescript-estree): don't consider a cached program unless it's s…

3f684bd

…pecified in the current `parserOptions.project` config

bradzacher mentioned this pull request

Nov 16, 2022

fix(typescript-estree): don't consider a cached program unless it's specified in the currentparserOptions.project config#5999

Merged

1 task

Copy link

MemberAuthor

bradzacher commentedNov 16, 2022•
edited
Loading

Interestingly the changes to that failing test have exposed a bug in our underlying project caching logic!
Fix is in#5999

I merged#5999 into this PR, so we'll have to wait for that one to land first.

bradzacher added the blocked by another PRPRs which are ready to go but waiting on another PR label

Nov 16, 2022

Merge branch 'fix-using-cached-program-incorrectly' into add-dep-cons…

49ebfa1

…traints-to-rule-tests

Copy link

codecovbot commentedNov 16, 2022•
edited
Loading

Codecov Report

Merging#5916 (9396b38) intomain (530e0e6) willdecrease coverage by0.13%.
The diff coverage is100.00%.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #5916      +/-   ##==========================================- Coverage   91.42%   91.29%   -0.14%==========================================  Files         365      365                Lines       12342    12343       +1       Branches     3610     3610              ==========================================- Hits        11284    11268      -16- Misses        753      767      +14- Partials      305      308       +3

Flag	Coverage Δ
unittest	`91.29% <100.00%> (-0.14%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...s/utils/src/eslint-utils/rule-tester/RuleTester.ts	`70.23% <100.00%> (-15.31%)`	⬇️
.../eslint-utils/rule-tester/dependencyConstraints.ts	`66.66% <0.00%> (-33.34%)`	⬇️