Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: bump minimum supported TS version to 4.2.4#5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 4 commits intov6frombump-min-ts-version
Nov 7, 2022

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedNov 2, 2022•
edited
Loading

BREAKING CHANGE:
Bumps the minimum supported range and removes handling for old versions

PR Checklist

Overview

DT hasn't bumped to 4.2 yet, but it's only just ticked to november, so I'd expect them to do it soon - likely before we do the major release.

This PR:

  • updates docs to clarify our version support windows
  • bumps the ranges around the place
  • removes no-longer-necessary checks for now outdated versions

BREAKING CHANGE:Bumps the minimum supported range and removes handling for old versions.Ref#1752
@bradzacherbradzacher added enhancementNew feature or request breaking changeThis change will require a new major version to be released labelsNov 2, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedNov 2, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0c29c34. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedNov 2, 2022•
edited
Loading

Codecov Report

Merging#5915 (0c29c34) intov6 (9b5fa0b) willincrease coverage by0.25%.
The diff coverage is100.00%.

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #5915      +/-   ##==========================================+ Coverage   91.44%   91.69%   +0.25%==========================================  Files         355      355                Lines       12058    12009      -49       Branches     3530     3518      -12     ==========================================- Hits        11026    11012      -14+ Misses        733      701      -32+ Partials      299      296       -3
FlagCoverage Δ
unittest91.69% <100.00%> (+0.25%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/typescript-estree/src/version-check.ts100.00% <ø> (ø)
...n/src/rules/no-non-null-asserted-optional-chain.ts100.00% <100.00%> (+53.33%)⬆️
...plugin/src/rules/no-unnecessary-type-constraint.ts100.00% <100.00%> (+12.00%)⬆️
packages/typescript-estree/src/convert.ts97.85% <100.00%> (+0.25%)⬆️
...pt-estree/src/create-program/createWatchProgram.ts83.79% <100.00%> (+5.73%)⬆️
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts93.33% <100.00%> (ø)

- We _generally_ do not officially support the `rc` releases.
- We endeavour to support the latest stable TypeScript versions as soon as possible after the release.

Generally we will begin working on supporting the next release when the `rc` version is released.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this decision documented anywhere? Now that we have more maintainer funding & people, it'd be nice to be able to support RC releases. But that's really hard and I'm guessing still not something worth it.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm all for us bumping versions and allowing RCs if we're able to - I just don't want us to set the expectation that we will support all RCs.

Sometimes releases are massive and and can take a lot of work to fully support.
Sometimes they have literally no impact for us.
Sometimes features from the beta get dropped from the RC.
Sometimes features from the RC get dropped from the full release.

There's just a lot of variability and with our limited bandwidth I don't want us to commit to anything!

JoshuaKGoldberg reacted with thumbs up emoji

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love to see all this code removal! Once the lints are fixed, 🚀

Copy link
Member

@JamesHenryJamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Beautiful!

@bradzacherbradzacher merged commitf66a15b intov6Nov 7, 2022
@bradzacherbradzacher deleted the bump-min-ts-version branchNovember 7, 2022 01:46
@bmishbmish mentioned this pull requestNov 13, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@Josh-CenaJosh-CenaJosh-Cena left review comments

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be releasedenhancementNew feature or request
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@bradzacher@JamesHenry@JoshuaKGoldberg@Josh-Cena
[8]ページ先頭
©2009-2025 Movatter.jp