Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add eslint:recommended to a usage example#591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intotypescript-eslint:masterfromborekb:patch-1
Jun 6, 2019

Conversation

borekb
Copy link
Contributor

Resolves#588.

@ThomasdenH
Copy link
Contributor

ThomasdenH commentedJun 5, 2019
edited
Loading

The recommended set is not entirely suitable for Typescript. Have a look atpackages/eslint-plugin/src/configs, there is a configuration that fixes that. It'd be great if you could add"plugin:@typescript-eslint/eslint-recommended", since it clearly isn't documented well enough.

@borekb
Copy link
ContributorAuthor

@ThomasdenH Good points, thanks! Will look into it later today.

@borekb
Copy link
ContributorAuthor

@ThomasdenH I tried to experiment with how various configs behave on our codebase and it lead me to create#592. Will happily document integration witheslint:recommended once it's clear to me how it's best done.

@bradzacher
Copy link
Member

bradzacher commentedJun 5, 2019
edited
Loading

The best integration would be:

[  'eslint:recommended',  // airbnb, etc  'plugin:@typescript-eslint/eslint-recommended',  'plugin:@typescript-eslint/recommended'  // prettier, etc]
borekb reacted with thumbs up emoji

@borekb
Copy link
ContributorAuthor

Great! Would you put it to the basic Usage section or dedicate a new one to it?

Another option is to link toeslint-plugin/src/configs which already has a good README about the various configs and probably a better chance to stay up to date :)

@bradzacher
Copy link
Member

I would say this should probably do a few things.
I doubt we'll add any more "recommended" style configs, and the configs readme is more there so I can direct people to it when they get their knickers in a knot over the recommended ruleset :)

Could you please do the following.

  • change the wording from
- You can also enable all the recommended rules at once. Add `plugin:@typescript-eslint/recommended` in extends:+ You can also enable all the recommended rules for our plugin. Add `plugin:@typescript-eslint/recommended` in extends:
  • add a new "section" below that along the lines of
You can also use eslint recommended with this plugin. Add both `eslint:recommended ` and `plugin:@typescript-eslint/eslint-recommended`:[  'eslint:recommended',  'plugin:@typescript-eslint/eslint-recommended',  'plugin:@typescript-eslint/recommended']

@borekb
Copy link
ContributorAuthor

@bradzacher great suggestions, thank you! Updated in2e6f60e.

@bradzacherbradzacher added the documentationDocumentation ("docs") that needs adding/updating labelJun 6, 2019
@bradzacherbradzacher merged commitc03b6ed intotypescript-eslint:masterJun 6, 2019
@borekbborekb deleted the patch-1 branchJune 6, 2019 15:48
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
documentationDocumentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention eslint:recommended in eslint-plugin's README?
3 participants
@borekb@ThomasdenH@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp