Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Add eslint:recommended to a usage example#591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
ThomasdenH commentedJun 5, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The recommended set is not entirely suitable for Typescript. Have a look atpackages/eslint-plugin/src/configs, there is a configuration that fixes that. It'd be great if you could add |
@ThomasdenH Good points, thanks! Will look into it later today. |
@ThomasdenH I tried to experiment with how various configs behave on our codebase and it lead me to create#592. Will happily document integration with |
bradzacher commentedJun 5, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The best integration would be:
|
Great! Would you put it to the basic Usage section or dedicate a new one to it? Another option is to link to |
I would say this should probably do a few things. Could you please do the following.
- You can also enable all the recommended rules at once. Add `plugin:@typescript-eslint/recommended` in extends:+ You can also enable all the recommended rules for our plugin. Add `plugin:@typescript-eslint/recommended` in extends:
|
@bradzacher great suggestions, thank you! Updated in2e6f60e. |
Resolves#588.