Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [no-shadow] handle false positives on generics and parameters#5902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/#5853
Nov 13, 2022

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloudbot commentedOct 29, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3652ffc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedOct 29, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3652ffc
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63717d405ced6000081028c4
😎 Deploy Previewhttps://deploy-preview-5902--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedOct 29, 2022
edited
Loading

Codecov Report

Merging#5902 (e4fa515) intomain (91d71bc) willdecrease coverage by0.02%.
The diff coverage is100.00%.

❗ Current heade4fa515 differs from pull request most recent head3652ffc. Consider uploading reports for the commit3652ffc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##             main    #5902      +/-   ##==========================================- Coverage   91.39%   91.37%   -0.03%==========================================  Files         365      365                Lines       12327    12193     -134       Branches     3606     3558      -48     ==========================================- Hits        11266    11141     -125+ Misses        755      747       -8+ Partials      306      305       -1
FlagCoverage Δ
unittest91.37% <100.00%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts77.52% <100.00%> (+1.68%)⬆️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts93.85% <0.00%> (-4.77%)⬇️
...gin/src/rules/naming-convention-utils/validator.ts95.54% <0.00%> (-1.28%)⬇️
...lugin-internal/src/rules/plugin-test-formatting.ts79.85% <0.00%> (-1.08%)⬇️
...kages/eslint-plugin/src/rules/naming-convention.ts81.09% <0.00%> (-0.77%)⬇️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts90.78% <0.00%> (-0.68%)⬇️
...eslint-plugin/src/rules/consistent-type-imports.ts94.26% <0.00%> (-0.29%)⬇️
packages/utils/src/ts-eslint/RuleTester.ts100.00% <0.00%> (ø)
.../eslint-plugin/src/rules/sort-type-constituents.ts90.74% <0.00%> (ø)
...-plugin/src/rules/naming-convention-utils/enums.ts100.00% <0.00%> (ø)
... and4 more

@bradzacherbradzacher added the bugSomething isn't working labelOct 31, 2022
@yeonjuanyeonjuan marked this pull request as ready for reviewOctober 31, 2022 03:02
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesNov 13, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯, thanks for fixing this@yeonjuan! 🚀

@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)November 13, 2022 23:26
@JoshuaKGoldbergJoshuaKGoldberg merged commit769e8c8 intotypescript-eslint:mainNov 13, 2022
@andsens
Copy link

Awesome stuff@yeonjuan! Thank you very much :-)

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestNov 15, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.42.1` -> `5.43.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.42.1/5.43.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.42.1` -> `5.43.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.42.1/5.43.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5430-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5421v5430-2022-11-14)[Compare Source](typescript-eslint/typescript-eslint@v5.42.1...v5.43.0)##### Bug Fixes-   **eslint-plugin:** \[no-shadow] handle false positives on generics and parameters ([#&#8203;5902](typescript-eslint/typescript-eslint#5902)) ([769e8c8](typescript-eslint/typescript-eslint@769e8c8))-   **eslint-plugin:** \[promise-function-async] handle keyword token ([#&#8203;5907](typescript-eslint/typescript-eslint#5907)) ([f25a94f](typescript-eslint/typescript-eslint@f25a94f))##### Features-   **eslint-plugin:** \[consistent-type-imports] support fixing to inline types ([#&#8203;5050](typescript-eslint/typescript-eslint#5050)) ([75dcdf1](typescript-eslint/typescript-eslint@75dcdf1))-   **eslint-plugin:** \[naming-convention] add support for "override" and "async" modifiers ([#&#8203;5310](typescript-eslint/typescript-eslint#5310)) ([#&#8203;5610](typescript-eslint/typescript-eslint#5610)) ([c759da1](typescript-eslint/typescript-eslint@c759da1))-   **eslint-plugin:** \[prefer-optional-chain] support suggesting `!foo || !foo.bar` as a valid match for the rule ([#&#8203;5594](typescript-eslint/typescript-eslint#5594)) ([923d486](typescript-eslint/typescript-eslint@923d486))#### [5.42.1](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) (2022-11-07)##### Bug Fixes-   **eslint-plugin:** isTypeReadonly stack overflow ([#&#8203;5875](typescript-eslint/typescript-eslint#5875)) ([#&#8203;5876](typescript-eslint/typescript-eslint#5876)) ([2d9a33c](typescript-eslint/typescript-eslint@2d9a33c))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5430-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5421v5430-2022-11-14)[Compare Source](typescript-eslint/typescript-eslint@v5.42.1...v5.43.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.42.1](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) (2022-11-07)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMSJ9-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1639Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [typescript-eslint/no-shadow] Rest (...args) parameter name in generic declaration shadows actual parameter name
4 participants
@yeonjuan@andsens@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp