Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-extra-parens] handle type assertion in extends clause#5901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfromyeonjuan:fix/#5899
Oct 30, 2022

Conversation

yeonjuan
Copy link
Contributor

@yeonjuanyeonjuan commentedOct 29, 2022•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloudbot commentedOct 29, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita45d113. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 29, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita45d113
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/635d42b79974d50008190f15
😎 Deploy Previewhttps://deploy-preview-5901--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedOct 29, 2022•
edited
Loading

Codecov Report

Merging#5901 (a45d113) intomain (891b087) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #5901   +/-   ##=======================================  Coverage   91.34%   91.35%           =======================================  Files         365      365             Lines       12193    12199    +6       Branches     3558     3560    +2     =======================================+ Hits        11138    11144    +6  Misses        749      749             Partials      306      306
FlagCoverage Δ
unittest91.35% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ackages/eslint-plugin/src/rules/no-extra-parens.ts91.46% <100.00%> (+0.67%)⬆️

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks reasonable so far, thanks for sending this in! 🙌

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelOct 29, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks! 🙌

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): [no-extra-parens] handle type assertion in extend…fix(eslint-plugin): [no-extra-parens] handle type assertion in extends clauseOct 30, 2022
@JoshuaKGoldbergJoshuaKGoldberg merged commit8ed7219 intotypescript-eslint:mainOct 30, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestNov 2, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.41.0/5.42.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.41.0/5.42.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31)[Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0)##### Bug Fixes-   **ast-spec:** add TSQualifiedName to TypeNode union ([#&#8203;5906](typescript-eslint/typescript-eslint#5906)) ([5c316c1](typescript-eslint/typescript-eslint@5c316c1))-   **eslint-plugin:** \[no-extra-parens] handle type assertion in extends clause ([#&#8203;5901](typescript-eslint/typescript-eslint#5901)) ([8ed7219](typescript-eslint/typescript-eslint@8ed7219))##### Features-   **eslint-plugin:** \[member-ordering] add natural sort order ([#&#8203;5662](typescript-eslint/typescript-eslint#5662)) ([1eaae09](typescript-eslint/typescript-eslint@1eaae09))-   **eslint-plugin:** \[no-invalid-void-type] better report message for void used as a constituent inside a function return type ([#&#8203;5274](typescript-eslint/typescript-eslint#5274)) ([d806bda](typescript-eslint/typescript-eslint@d806bda))</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31)[Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0)##### Features-   **scope-manager:** ignore ECMA version ([#&#8203;5881](typescript-eslint/typescript-eslint#5881)) ([3b8d449](typescript-eslint/typescript-eslint@3b8d449))##### Reverts-   Revert "feat(scope-manager): ignore ECMA version" ([#&#8203;5888](typescript-eslint/typescript-eslint#5888)) ([2ee81df](typescript-eslint/typescript-eslint@2ee81df)), closes [#&#8203;5888](typescript-eslint/typescript-eslint#5888) [#&#8203;5881](typescript-eslint/typescript-eslint#5881)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xMC4wIn0=-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1619Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: @typescript-eslint/no-extra-parens applying erroneously to class extensions
2 participants
@yeonjuan@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp