Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(utils): addRuleTester API for top-level dependency constraints#5896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 5 commits intomainfromtop-level-dependency-constraints-for-tests
Oct 31, 2022

Conversation

bradzacher
Copy link
Member

Overview

As I continued working on#5573, I realised that there are some plugin rules that won't ever work on old versions of TS.
For exampleconsistent-type-imports hard requires at least TS 4.1 as that was the first version where the required syntax was added.

This PR adds a new API to the rule tester that allows you to list a set of dependency constraints for all tests in the rule tester constructor. If the constraints don't pass then absolutely no tests are run.

@bradzacherbradzacher added the enhancementNew feature or request labelOct 27, 2022
@nx-cloud
Copy link

nx-cloudbot commentedOct 27, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit48c1196. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 27, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit48c1196
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/635fad57b6a5b700083e118c
😎 Deploy Previewhttps://deploy-preview-5896--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedOct 27, 2022•
edited
Loading

Codecov Report

Merging#5896 (48c1196) intomain (1f14c03) willdecrease coverage by0.03%.
The diff coverage is64.70%.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #5896      +/-   ##==========================================- Coverage   91.35%   91.32%   -0.04%==========================================  Files         365      365                Lines       12199    12212      +13       Branches     3560     3564       +4     ==========================================+ Hits        11144    11152       +8- Misses        749      752       +3- Partials      306      308       +2
FlagCoverage Δ
unittest91.32% <64.70%> (-0.04%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/utils/src/ts-eslint/RuleTester.ts100.00% <ø> (ø)
...s/utils/src/eslint-utils/rule-tester/RuleTester.ts85.54% <64.70%> (-4.46%)⬇️

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesOct 27, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome, looks good to me! Just a few non-blocking suggestions, along with an error message typo fix.

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesOct 29, 2022
@bradzacherbradzacher merged commit0520d53 intomainOct 31, 2022
@bradzacherbradzacher deleted the top-level-dependency-constraints-for-tests branchOctober 31, 2022 12:03
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bradzacher@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp