typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): enable react/jsx-curly-brace-presence lint rule in website package#5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromshogohida:enable-react/jsx-curly-brace-presence

Oct 27, 2022

Merged

fix(eslint-plugin): enable react/jsx-curly-brace-presence lint rule in website package#5894

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromshogohida:enable-react/jsx-curly-brace-presence

Oct 27, 2022

Conversation

Copy link

Contributor

shogohida commentedOct 26, 2022•
edited by JoshuaKGoldberg
Loading

PR Checklist

Addresses an existing open issue:fixesRepo: Enable react/jsx-curly-brace-presence lint rule in website package #5878
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Copy link

nx-cloudbot commentedOct 26, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita51a1c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedOct 26, 2022

Thanks for the PR,@shogohida!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedOct 26, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`a51a1c8`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/635a11a3e61fea000857c88e
😎 Deploy Preview	https://deploy-preview-5894--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

ContributorAuthor

shogohida commentedOct 26, 2022•
edited
Loading

I couldn't run lint locally for some reason so I decided to make a draft pull request to see which code I need to fix afterreact/jsx-curly-brace-presence is enabled.

Maybe it was because I faced the same issue as below.
eslint/eslint#15785

Add 'react/jsx-curly-brace-presence': 'error'

b1771a1

shogohida force-pushed theenable-react/jsx-curly-brace-presence branch from025fd0c tob1771a1Compare

October 26, 2022 12:39

shogohida mentioned this pull request

Oct 27, 2022

Repo: Enable react/jsx-curly-brace-presence lint rule in website package#5878

Closed

JoshuaKGoldberg approved these changes

Oct 27, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, glad to see no issues were detected here! Thanks for sending this in! ✨

JoshuaKGoldberg marked this pull request as ready for review

October 27, 2022 05:05

Merge branch 'main' into enable-react/jsx-curly-brace-presence

a51a1c8

JoshuaKGoldbergenabled auto-merge (squash)

October 27, 2022 05:05

Copy link

codecovbot commentedOct 27, 2022

Codecov Report

Merging#5894 (b1771a1) intomain (67744db) willincrease coverage by0.03%.
The diff coverage is89.92%.

❗ Current headb1771a1 differs from pull request most recent heada51a1c8. Consider uploading reports for the commita51a1c8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #5894      +/-   ##==========================================+ Coverage   91.33%   91.36%   +0.03%==========================================  Files         361      364       +3       Lines       12044    12134      +90       Branches     3506     3540      +34     ==========================================+ Hits        11000    11086      +86  Misses        748      748- Partials      296      300       +4

Flag	Coverage Δ
unittest	`91.36% <89.92%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ript-estree/src/create-program/createSourceFile.ts	`87.50% <0.00%> (ø)`
...t-estree/src/create-program/useProvidedPrograms.ts	`84.84% <50.00%> (ø)`
...-estree/src/create-program/createDefaultProgram.ts	`78.26% <71.42%> (+0.98%)`	⬆️
...ges/typescript-estree/src/create-program/shared.ts	`83.33% <75.00%> (ø)`
...pt-estree/src/create-program/createWatchProgram.ts	`78.06% <78.57%> (ø)`
...-estree/src/create-program/createProjectProgram.ts	`93.47% <81.81%> (ø)`
...escript-estree/src/parseSettings/inferSingleRun.ts	`90.90% <90.90%> (ø)`
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts	`93.33% <93.33%> (ø)`
...pt-estree/src/parseSettings/createParseSettings.ts	`96.82% <96.82%> (ø)`
packages/typescript-estree/src/ast-converter.ts	`100.00% <100.00%> (ø)`
... and1 more