Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(scope-manager): ignore ECMA version#5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

BREAKING CHANGE:
Removes part of the public API for the parser and scope-manager.

PR Checklist

Overview

Per the issue, ignoresecmaVersion in the options, and assumes it's always ESNext.

JoshuaKGoldbergand others added9 commitsOctober 25, 2022 10:45
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedOct 26, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit04e8bed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@bradzacherbradzacher linked an issueOct 26, 2022 that may beclosed by this pull request
@codecov
Copy link

codecovbot commentedOct 26, 2022•
edited
Loading

Codecov Report

Merging#5889 (04e8bed) intov6 (c4e0d86) willincrease coverage by0.02%.
The diff coverage is88.35%.

Additional details and impacted files
@@            Coverage Diff             @@##               v6    #5889      +/-   ##==========================================+ Coverage   91.33%   91.35%   +0.02%==========================================  Files         361      364       +3       Lines       12044    12185     +141       Branches     3506     3546      +40     ==========================================+ Hits        11000    11132     +132- Misses        748      752       +4- Partials      296      301       +5
FlagCoverage Δ
unittest91.35% <88.35%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/scope-manager/src/ScopeManager.ts77.21% <0.00%> (-2.54%)⬇️
packages/scope-manager/src/analyze.ts57.89% <0.00%> (-7.49%)⬇️
...ript-estree/src/create-program/createSourceFile.ts87.50% <0.00%> (ø)
...t-estree/src/create-program/useProvidedPrograms.ts84.84% <50.00%> (ø)
...-estree/src/create-program/createDefaultProgram.ts78.26% <71.42%> (+0.98%)⬆️
...ges/typescript-estree/src/create-program/shared.ts83.33% <75.00%> (ø)
...pt-estree/src/create-program/createWatchProgram.ts78.06% <78.57%> (ø)
...-estree/src/create-program/createProjectProgram.ts93.47% <81.81%> (ø)
...escript-estree/src/parseSettings/inferSingleRun.ts90.90% <90.90%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts93.33% <93.33%> (ø)
... and8 more

@JoshuaKGoldbergJoshuaKGoldberg merged commitc446386 intotypescript-eslint:v6Oct 26, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the scope-manager-ignore-ecma-version branchOctober 26, 2022 03:13
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
@JoshuaKGoldbergJoshuaKGoldberg added this to the6.0.0 milestoneDec 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[scope-manager] should ignoreparserOptions.ecmaVersion
3 participants
@JoshuaKGoldberg@bradzacher@adnanhashmi09
[8]ページ先頭
©2009-2025 Movatter.jp