Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: v6.0.0#5886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 179 commits intomainfromv6
Jul 10, 2023
Merged

chore: v6.0.0#5886

JoshuaKGoldberg merged 179 commits intomainfromv6
Jul 10, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedOct 26, 2022•
edited
Loading

BREAKING CHANGE: v6, hooray! 🥳

This PR contains all of the changes for v6.0.0.
We willrebase merge this ontomain

theoludwig and andriyor reacted with heart emojitheoludwig and andriyor reacted with rocket emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedOct 26, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf0f45a9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 51 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedOct 26, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3201f78
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64ac4142c9eaa20007c5f8f3
😎 Deploy Previewhttps://deploy-preview-5886--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg added this to the6.0.0 milestoneOct 26, 2022
@bmish
Copy link
Contributor

Is it time to drop ESLint v6 support from peer deps? It was released in 2019:https://eslint.org/blog/2019/06/eslint-v6.0.0-released/

"peerDependencies": {  "eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"},
MichaelDeBoey reacted with thumbs up emoji

@bmish
Copy link
Contributor

What do you think of strictly-defining the Node API withexports in each package?

This would follow the lead of ESLint core and other ESLint plugins so that users cannot reach in and import/depend on arbitrary files inside the package.

  • https://eslint.org/docs/latest/user-guide/migrating-to-8.0.0#remove-lib

    Beginning in v8.0.0, ESLint is strictly defining its public API. Previously, you could reach into individual files such as require("eslint/lib/rules/semi") and this is no longer allowed. There are a limited number of existing APIs that are now available through the /use-at-your-own-risk entrypoint for backwards compatibility, but these APIs are not formally supported and may break or disappear at any point in time.

https://nodejs.org/api/packages.html#main-entry-point-export

MichaelDeBoey reacted with thumbs up emoji

@bmishbmish mentioned this pull requestNov 11, 2022
3 tasks
@bradzacher
Copy link
Member

What do you think of strictly-defining the Node API with exports in each package?

We're all for it -#5586

bmish reacted with thumbs up emoji

@bradzacher
Copy link
Member

Is it time to drop ESLint v6 support from peer deps?

Sounds good to me! Last major we dropped v5 support - so happy to do it.
Filed#5968 to track

bmish and MichaelDeBoey reacted with thumbs up emoji

@bmish
Copy link
Contributor

bmish commentedNov 11, 2022•
edited
Loading

In case you guys aren't already tracking it, I see a lot of "TODO" /@deprecated / deprecated comments throughout the codebase mentioning breaking changes that would be good to make now.

@bmish
Copy link
Contributor

I also see 5 deprecated rules that could be deleted.

@JoshuaKGoldberg
Copy link
MemberAuthor

@bmish thanks for pointing these out! Anything that we've marked as deprecated (should be removed in general) deserves an issue tracking it. If you see anything that doesn't yet have one, feel free to file it!

I want to eventually do a sweep but haven't had the time. 🥲

Andaristand others added5 commitsNovember 23, 2022 16:40
)* refactor(utils)!: removed `TRuleListener` generic from the `createRule`* refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction`* chore: document and refactor 'extra' to 'parserSettings' (#5834)* chore(website): fix renamed Sponsorship docs link (#5882)* docs: Mention wide globs performance implications in monorepos docs and parser README (#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
* feat: update TSImportType node* fix: update visitor keys* chore: document and refactor 'extra' to 'parserSettings' (#5834)* chore(website): fix renamed Sponsorship docs link (#5882)* docs: Mention wide globs performance implications in monorepos docs and parser README (#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
* feat(scope-manager): ignore ECMA version* chore: document and refactor 'extra' to 'parserSettings' (#5834)* chore(website): fix renamed Sponsorship docs link (#5882)* Remove much more* Fix WebLinter lint* docs: Mention wide globs performance implications in monorepos docs and parser README (#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>* chore: add auto-canary release for v6 (#5883)Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…TSInterfaceDeclaration and TSModuleDeclaration (#4863)* chore: remove invalid properties from ast nodes* chore: remove invalid code in scope-manager and typescript-estree* chore: re-write snapshots that were using invalid properties* feat: remove modifiers union from ast typesCo-authored-by: Juan García <juank1809@gmail.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
JoshuaKGoldbergand others added11 commitsJune 18, 2023 09:25
* feat(eslint-plugin): apply final v6 changes to configs* Ah, fixed new lint rule violations internally* no-mixed-enums strict* Apply suggestions from code reviewCo-authored-by: Brad Zacher <brad.zacher@gmail.com>* Fix up build & lint issues* Never mind, prefer nullish coalescing---------Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
* chore: enabled stylistic-type-checked internally* Reduced scope of changes* Updated snapshots* Update packages/typescript-estree/tests/lib/convert.test.tsCo-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>* More deeplyCopy removals* Updated test snapshots---------Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>
* feat(eslint-plugin): final final config changes for v6* yarn generate:configs* Fix unused lint suppression complaint and test snapshot* unknown, not any, in recommended-does-not-require-program* Updated endColumn
@JoshuaKGoldberg
Copy link
MemberAuthor

JoshuaKGoldberg commentedJul 4, 2023•
edited
Loading

Ran into some gnarly merge conflicts. Fixed most of them but ran out of time for the rest. Will finish soon. ✅

JoshuaKGoldbergand others added8 commitsJuly 6, 2023 15:41
…irst operands are unrelated to the rest of the chain and add type info (#6397)
…ver match error types (#6869)* fix(type-utils): treat intrinsic types as if they are from lib and never match error types* Update packages/type-utils/tests/TypeOrValueSpecifier.test.ts* chore: bump ts-api-utils to 1.0.1* refactor: use isIntrinsicErrorType---------Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@JoshuaKGoldbergJoshuaKGoldberg merged commitca1abb5 intomainJul 10, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 18, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@fiskerfiskerfisker left review comments

@bmishbmishbmish left review comments

@MichaelDeBoeyMichaelDeBoeyMichaelDeBoey left review comments

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

12 participants
@JoshuaKGoldberg@bmish@bradzacher@fisker@MichaelDeBoey@Andarist@armano2@juank1809@kball@marekdedic@RebeccaStevens@takanome-dev
[8]ページ先頭
©2009-2025 Movatter.jp