Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): wrap import = declaration in an export node#5885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedOct 25, 2022•
edited
Loading

BREAKING CHANGE:
Removes AST property and changes AST structure

PR Checklist

Overview

A note from our pairing: it's fine to create as many (multiple) nodes as we like from one original node.

Co-authored-by: Brad Zacherbrad.zacher@gmail.com

armano2 reacted with thumbs up emoji
@nx-cloud
Copy link

nx-cloudbot commentedOct 25, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit79a5f81. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedOct 25, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit7a25528
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63586cb819d7ed0008f64301
😎 Deploy Previewhttps://deploy-preview-5885--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Andaristand others added2 commitsOctober 25, 2022 19:59
…pescript-eslint#5036)* refactor(utils)!: removed `TRuleListener` generic from the `createRule`* refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction`* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…ipt-eslint#3076)* feat: update TSImportType node* fix: update visitor keys* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
@bradzacherbradzacher added the breaking changeThis change will require a new major version to be released labelOct 26, 2022
@bradzacherbradzacher changed the base branch frommain tov6October 26, 2022 01:41
@bradzacherbradzacher added this to the6.0.0 milestoneOct 26, 2022
JoshuaKGoldbergand others added8 commitsOctober 25, 2022 23:12
* feat(scope-manager): ignore ECMA version* chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834)* chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882)* Remove much more* Fix WebLinter lint* docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>* chore: add auto-canary release for v6 (typescript-eslint#5883)Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…TSInterfaceDeclaration and TSModuleDeclaration (typescript-eslint#4863)* chore: remove invalid properties from ast nodes* chore: remove invalid code in scope-manager and typescript-estree* chore: re-write snapshots that were using invalid properties* feat: remove modifiers union from ast typesCo-authored-by: Juan García <juank1809@gmail.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
* chore(utils)\!: remove (ts-)eslint-scope types* Remove eslint-scope dep* More file deletions
@codecov
Copy link

codecovbot commentedDec 16, 2022•
edited
Loading

Codecov Report

Merging#5885 (79a5f81) intov6 (9c17395) willnot change coverage.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##               v6    #5885   +/-   ##=======================================  Coverage   91.87%   91.87%           =======================================  Files         359      359             Lines       12400    12400             Branches     3653     3653           =======================================  Hits        11393    11393             Misses        703      703             Partials      304      304
FlagCoverage Δ
unittest91.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/typescript-estree/src/convert.ts97.19% <100.00%> (ø)

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewDecember 16, 2022 20:09
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

futureisnow_oldman

@bradzacher
Copy link
Member

I think this needs a rebase before merging?

@JoshuaKGoldbergJoshuaKGoldberg merged commit1c3f470 intotypescript-eslint:v6Feb 4, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the import-equals-wrap-node branchFebruary 4, 2023 17:27
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

An exportedTSImportEqualsDeclaration should be wrapped in anExportNamedDeclaration instead of having.isExport = true
5 participants
@JoshuaKGoldberg@bradzacher@Andarist@armano2@juank1809
[8]ページ先頭
©2009-2025 Movatter.jp