Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(scope-manager): ignore ECMA version#5881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(scope-manager): ignore ECMA version#5881
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
nx-cloudbot commentedOct 25, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
netlifybot commentedOct 25, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
Uh oh!
There was an error while loading.Please reload this page.
codecovbot commentedOct 25, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #5881 +/- ##==========================================- Coverage 91.36% 91.34% -0.02%========================================== Files 364 364 Lines 12134 12123 -11 Branches 3540 3530 -10 ==========================================- Hits 11086 11074 -12- Misses 748 750 +2+ Partials 300 299 -1
Flags with carried forward coverage won't be shown.Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we can also remove the code from higher up the chain!
start from here and work your way down!
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/src/parser.ts#L108
Uh oh!
There was an error while loading.Please reload this page.
| @@ -122,7 +95,7 @@ function analyze( | |||
| jsxFragmentName: | |||
| providedOptions?.jsxFragmentName ?? DEFAULT_OPTIONS.jsxFragmentName, | |||
| sourceType: providedOptions?.sourceType ?? DEFAULT_OPTIONS.sourceType, | |||
| lib: providedOptions?.lib ?? [mapEcmaVersion(ecmaVersion)], | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hmmm. I wonder if maybe I was too over-zealous with my recommendation to cull higher?
Having this auto-resolved is a really nice property. For the most part it shouldn't cause any issues for people (it just includes a few more global variables for people using rules likeno-undef orno-use-before-define), but there might be edge cases?
Hmm. WDYT? I'm torn on if it's worth the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Neither of those are rules we recommend folks use - and folks should generally always be in >=ES2021 or so these days. I say let's kill them for now, and use the RC period to see if anybody notices! 🔪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh I will mark this as a breaking change now though.
AGH the branch change to |
This reverts commit3b8d449.
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.41.0/5.42.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.41.0` -> `5.42.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.41.0/5.42.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary>### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31)[Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0)##### Bug Fixes- **ast-spec:** add TSQualifiedName to TypeNode union ([#​5906](typescript-eslint/typescript-eslint#5906)) ([5c316c1](typescript-eslint/typescript-eslint@5c316c1))- **eslint-plugin:** \[no-extra-parens] handle type assertion in extends clause ([#​5901](typescript-eslint/typescript-eslint#5901)) ([8ed7219](typescript-eslint/typescript-eslint@8ed7219))##### Features- **eslint-plugin:** \[member-ordering] add natural sort order ([#​5662](typescript-eslint/typescript-eslint#5662)) ([1eaae09](typescript-eslint/typescript-eslint@1eaae09))- **eslint-plugin:** \[no-invalid-void-type] better report message for void used as a constituent inside a function return type ([#​5274](typescript-eslint/typescript-eslint#5274)) ([d806bda](typescript-eslint/typescript-eslint@d806bda))</details><details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary>### [`v5.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31)[Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0)##### Features- **scope-manager:** ignore ECMA version ([#​5881](typescript-eslint/typescript-eslint#5881)) ([3b8d449](typescript-eslint/typescript-eslint@3b8d449))##### Reverts- Revert "feat(scope-manager): ignore ECMA version" ([#​5888](typescript-eslint/typescript-eslint#5888)) ([2ee81df](typescript-eslint/typescript-eslint@2ee81df)), closes [#​5888](typescript-eslint/typescript-eslint#5888) [#​5881](typescript-eslint/typescript-eslint#5881)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xMC4wIn0=-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1619Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Uh oh!
There was an error while loading.Please reload this page.
BREAKING CHANGE:
Removes part of the public API for the parser and scope-manager.
PR Checklist
parserOptions.ecmaVersion#2900Overview
Per the issue, ignores
ecmaVersionin the options, and assumes it's always ESNext.