Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin) [sort-type-union-intersection-members] rename to sort-type-constituents#5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedOct 25, 2022•
edited
Loading

PR Checklist

Overview

Directly renames the rule and its messages.

@JoshuaKGoldbergJoshuaKGoldberg added the breaking changeThis change will require a new major version to be released labelOct 25, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedOct 25, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit03bcb7f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedOct 25, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit03bcb7f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/635a066aacbfb90008078578
😎 Deploy Previewhttps://deploy-preview-5879--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewOctober 25, 2022 14:39
@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov6October 25, 2022 21:15
@bradzacherbradzacher added this to the6.0.0 milestoneOct 25, 2022
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

note: if we wanted to do this now we could actually do it ahead of the v6 release - we'd just need to leave the old name alive for now and mark it asreplacedBy

image

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 26, 2022
@JoshuaKGoldberg
Copy link
MemberAuthor

Oh, I forgot aboutreplacedBy! Yes - will do.

@JoshuaKGoldbergJoshuaKGoldberg removed the breaking changeThis change will require a new major version to be released labelOct 26, 2022
@bradzacherbradzacher removed this from the6.0.0 milestoneOct 26, 2022
@codecov
Copy link

codecovbot commentedOct 26, 2022•
edited
Loading

Codecov Report

Merging#5879 (03bcb7f) intomain (2ee81df) willdecrease coverage by0.00%.
The diff coverage is90.74%.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #5879      +/-   ##==========================================- Coverage   91.36%   91.36%   -0.01%==========================================  Files         364      365       +1       Lines       12134    12188      +54       Branches     3540     3554      +14     ==========================================+ Hits        11086    11135      +49- Misses        748      749       +1- Partials      300      304       +4
FlagCoverage Δ
unittest91.36% <90.74%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
.../src/rules/sort-type-union-intersection-members.ts90.74% <ø> (ø)
.../eslint-plugin/src/rules/sort-type-constituents.ts90.74% <90.74%> (ø)

bradzacher
bradzacher previously approved these changesOct 27, 2022
@JoshuaKGoldbergJoshuaKGoldberg changed the base branch fromv6 tomainOctober 27, 2022 04:17
@JoshuaKGoldbergJoshuaKGoldberg dismissedbradzacher’sstale reviewOctober 27, 2022 04:17

The base branch was changed.

@JoshuaKGoldbergJoshuaKGoldberg merged commita0c8285 intotypescript-eslint:mainOct 27, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the rename-sort-type-union-intersection-members branchOctober 27, 2022 05:03
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename sort-type-union-intersection-members to sort-type-constituents
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp