Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: Mention wide globs performance implications in monorepos docs and parser README#5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

adnanhashmi09
Copy link
Contributor

PR Checklist

Overview

Adds a mention of the performance issues with** inmonorepo docs andparser's README a link to the issue.

@nx-cloud
Copy link

nx-cloudbot commentedOct 24, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitb02bbb5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@adnanhashmi09!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedOct 24, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitb02bbb5
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/635862591c20500009464037
😎 Deploy Previewhttps://deploy-preview-5864--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@adnanhashmi09
Copy link
ContributorAuthor

@JoshuaKGoldberg Please review this PR and suggest any necessary changes.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesOct 24, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks!

Long term if we keep adding to this page we might want to shorten the size of those.eslintrc.js code blocks. But for now I think it's fine - and helps emphasize our recommended config starter.

@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)October 24, 2022 19:15
@bradzacherbradzacher added the documentationDocumentation ("docs") that needs adding/updating labelOct 25, 2022
@JoshuaKGoldbergJoshuaKGoldberg merged commitfcf3f9d intotypescript-eslint:mainOct 25, 2022
JoshuaKGoldberg added a commit that referenced this pull requestOct 25, 2022
)* refactor(utils)!: removed `TRuleListener` generic from the `createRule`* refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction`* chore: document and refactor 'extra' to 'parserSettings' (#5834)* chore(website): fix renamed Sponsorship docs link (#5882)* docs: Mention wide globs performance implications in monorepos docs and parser README (#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
JoshuaKGoldberg added a commit that referenced this pull requestOct 26, 2022
* feat: update TSImportType node* fix: update visitor keys* chore: document and refactor 'extra' to 'parserSettings' (#5834)* chore(website): fix renamed Sponsorship docs link (#5882)* docs: Mention wide globs performance implications in monorepos docs and parser README (#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
JoshuaKGoldberg added a commit that referenced this pull requestOct 26, 2022
* feat(scope-manager): ignore ECMA version* chore: document and refactor 'extra' to 'parserSettings' (#5834)* chore(website): fix renamed Sponsorship docs link (#5882)* Remove much more* Fix WebLinter lint* docs: Mention wide globs performance implications in monorepos docs and parser README (#5864)* docs: Mention wide globs performance implications in monorepos docs and parser readme* Update docs/linting/typed-linting/MONOREPOS.mdCo-authored-by: Josh Goldberg <git@joshuakgoldberg.com>* chore: add auto-canary release for v6 (#5883)Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
documentationDocumentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs:parserOptions.project may have performance implications when using** glob patterns
3 participants
@adnanhashmi09@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp