Oct 24, 2022 · Oct 23, 2022 · Oct 24, 2022
diff --git a/packages/eslint-plugin/tests/rules/prefer-readonly-parameter-types.test.ts b/packages/eslint-plugin/tests/rules/prefer-readonly-parameter-types.test.ts
  InferMessageIdsTypeFromRule,
  InferOptionsTypeFromRule,
 } from '../../src/util';
 import { readonlynessOptionsDefaults } from '../../src/util';
 import { getFixturesRootDir, noFormat, RuleTester } from '../RuleTester';

 type MessageIds = InferMessageIdsTypeFromRule<typeof rule>;
        },
      ],
    },
    {
      name: 'circular readonly types (Bug: #4476)',
      code: `
        interface Obj {
          readonly [K: string]: Obj;
        }

        function foo(event: Obj): void {}
      `,
      options: [
        {
          checkParameterProperties: true,
          ignoreInferredTypes: false,
          ...readonlynessOptionsDefaults,
        },
      ],
    },
  ],
  invalid: [
    // arrays
diff --git a/packages/type-utils/src/isTypeReadonly.ts b/packages/type-utils/src/isTypeReadonly.ts
        return Readonlyness.Mutable;
      }

      if (indexInfo.type === type) {
        return Readonlyness.Readonly;
      }

      return isTypeReadonlyRecurser(
        checker,
        indexInfo.type,
diff --git a/packages/type-utils/tests/isTypeReadonly.test.ts b/packages/type-utils/tests/isTypeReadonly.test.ts
          );
        });

        describe('is readonly circular', () => {
          const runTests = runTestIsReadonly;

          it('handles circular readonly PropertySignature inside a readonly IndexSignature', () =>
            runTests('interface Test { readonly [key: string]: Test };'));
        });

        describe('is not readonly', () => {
          const runTests = runTestIsNotReadonly;

            runTests,
          );
        });

        describe('is not readonly circular', () => {
          const runTests = runTestIsNotReadonly;

          it('handles circular mutable PropertySignature inside a readonly IndexSignature', () =>
            runTests('interface Test { [key: string]: Test };'));
        });
      });

      describe('Union', () => {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,6 +5,7 @@ import type {
		InferMessageIdsTypeFromRule,
		InferOptionsTypeFromRule,
		} from '../../src/util';
		import { readonlynessOptionsDefaults } from '../../src/util';
		import { getFixturesRootDir, noFormat, RuleTester } from '../RuleTester';

		type MessageIds = InferMessageIdsTypeFromRule<typeof rule>;
Expand DownExpand Up		@@ -362,6 +363,23 @@ ruleTester.run('prefer-readonly-parameter-types', rule, {
		},
		],
		},
		{
		name: 'circular readonly types (Bug: #4476)',
		code: `
		interface Obj {
		readonly [K: string]: Obj;
		}

		function foo(event: Obj): void {}
		`,
		options: [
		{
		checkParameterProperties: true,
		ignoreInferredTypes: false,
		...readonlynessOptionsDefaults,
		},
		],
		},
		],
		invalid: [
		// arrays
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -113,6 +113,10 @@ function isTypeReadonlyObject(
		return Readonlyness.Mutable;
		}

		if (indexInfo.type === type) {
		return Readonlyness.Readonly;
		}

		return isTypeReadonlyRecurser(
		checker,
		indexInfo.type,
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -134,6 +134,13 @@ describe('isTypeReadonly', () => {
		);
		});

		describe('is readonly circular', () => {
		const runTests = runTestIsReadonly;

		it('handles circular readonly PropertySignature inside a readonly IndexSignature', () =>
		runTests('interface Test { readonly [key: string]: Test };'));
		});

		describe('is not readonly', () => {
		const runTests = runTestIsNotReadonly;

Expand All		@@ -145,6 +152,13 @@ describe('isTypeReadonly', () => {
		runTests,
		);
		});

		describe('is not readonly circular', () => {
		const runTests = runTestIsNotReadonly;

		it('handles circular mutable PropertySignature inside a readonly IndexSignature', () =>
		runTests('interface Test { [key: string]: Test };'));
		});
		});

		describe('Union', () => {
Expand Down