typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(type-utils): prevent stack overflow in`isTypeReadonly`#5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromMillerSvt:fix/4476

Oct 24, 2022

Merged

fix(type-utils): prevent stack overflow in`isTypeReadonly`#5860

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromMillerSvt:fix/4476

Oct 24, 2022

Conversation

Copy link

Contributor

sviat9440 commentedOct 23, 2022

PR Checklist

Addresses an existing open issue:fixesBug: [prefer-readonly-parameter-types]isTypeReadonly stack overflow #4476
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Copy link

nx-cloudbot commentedOct 23, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit2d24a1b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedOct 23, 2022

Thanks for the PR,@sviat9440!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedOct 23, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`2d24a1b`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6356c99068bf100008e28f34
😎 Deploy Preview	https://deploy-preview-5860--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

sviat9440 force-pushed thefix/4476 branch 2 times, most recently from3c73b21 to67eba41Compare

October 23, 2022 19:28

Copy link

codecovbot commentedOct 23, 2022•
edited
Loading

Codecov Report

Merging#5860 (9d10030) intomain (e70a10a) willincrease coverage by0.02%.
The diff coverage is100.00%.

❗ Current head9d10030 differs from pull request most recent head2d24a1b. Consider uploading reports for the commit2d24a1b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #5860      +/-   ##==========================================+ Coverage   91.32%   91.35%   +0.02%==========================================  Files         361      361                Lines       12028    12026       -2       Branches     3502     3500       -2     ==========================================+ Hits        10985    10986       +1+ Misses        747      743       -4- Partials      296      297       +1

Flag	Coverage Δ
unittest	`91.35% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/type-utils/src/isTypeReadonly.ts	`86.00% <100.00%> (+0.28%)`	⬆️
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`100.00% <0.00%> (ø)`
...-plugin/src/rules/no-unsafe-declaration-merging.ts	`92.85% <0.00%> (+15.07%)`	⬆️

fix(eslint-plugin): isTypeReadonly stack overflow (typescript-eslint#…

9d10030

…4476)

sviat9440 force-pushed thefix/4476 branch from67eba41 to9d10030Compare

October 23, 2022 21:00

bradzacher changed the title~~fix(eslint-plugin): isTypeReadonly stack overflow (#4476)~~fix(type-utils): prevent stack overflow inisTypeReadonly

Oct 24, 2022

bradzacher added the bugSomething isn't working label

Oct 24, 2022

Copy link

ContributorAuthor

sviat9440 commentedOct 24, 2022

Another fail test case:

interface Test {   readonly [key: string]: Test1;}interface Test1 {  readonly [key: string]: Test;}

sviat9440 marked this pull request as draft

October 24, 2022 15:22

JoshuaKGoldberg approved these changes

Oct 24, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - confirmed that undoing the fix toisTypeReadonly.ts makes one of the added unit tests crash withRangeError: Maximum call stack size exceeded. Thanks!

Merge branch 'main' into fix/4476

2d24a1b

Copy link

Member

JoshuaKGoldberg commentedOct 24, 2022

Pardon my intrusiveness@sviat9440, this looks perfect as-is and I want to get it in before our next release later today. Marking as ready for review 😄

JoshuaKGoldberg marked this pull request as ready for review

October 24, 2022 17:21

JoshuaKGoldbergenabled auto-merge (squash)

October 24, 2022 17:21

JoshuaKGoldberg merged commita6d8f7e intotypescript-eslint:main

Oct 24, 2022

Copy link

Member

JoshuaKGoldberg commentedOct 24, 2022

https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.41.0

Copy link

ContributorAuthor

sviat9440 commentedOct 24, 2022

ok, I will fix the other case in the next pr

sync-by-unitobot mentioned this pull request

Oct 25, 2022

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.36.1 to 5.41.0numbersprotocol/capture-lite#2211

Closed

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

Oct 25, 2022

Update typescript-eslint monorepo to v5.41.0 (#1604)

659bcaa

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.40.1` -> `5.41.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.40.1/5.41.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.40.1` -> `5.41.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.40.1/5.41.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5410-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5401v5410-2022-10-24)[Compare Source](typescript-eslint/typescript-eslint@v5.40.1...v5.41.0)##### Bug Fixes-   **eslint-plugin:** \[no-base-to-string] ignore Error, URL, and URLSearchParams by default ([#&#8203;5839](typescript-eslint/typescript-eslint#5839)) ([96e1c6c](typescript-eslint/typescript-eslint@96e1c6c))-   **type-utils:** prevent stack overflow in `isTypeReadonly` ([#&#8203;5860](typescript-eslint/typescript-eslint#5860)) ([a6d8f7e](typescript-eslint/typescript-eslint@a6d8f7e)), closes [#&#8203;4476](typescript-eslint/typescript-eslint#4476)##### Features-   **eslint-plugin:** \[no-unsafe-declaration-merging] switch to use scope analysis instead of type information ([#&#8203;5865](typescript-eslint/typescript-eslint#5865)) ([e70a10a](typescript-eslint/typescript-eslint@e70a10a))-   **eslint-plugin:** add no-unsafe-declaration-merging ([#&#8203;5840](typescript-eslint/typescript-eslint#5840)) ([3728031](typescript-eslint/typescript-eslint@3728031))#### [5.40.1](typescript-eslint/typescript-eslint@v5.40.0...v5.40.1) (2022-10-17)##### Bug Fixes-   **eslint-plugin:** Skip missing 'rest' tuple type arguments in no-misused-promises ([#&#8203;5809](typescript-eslint/typescript-eslint#5809)) ([c5beaa2](typescript-eslint/typescript-eslint@c5beaa2)), closes [#&#8203;5807](typescript-eslint/typescript-eslint#5807)</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5410-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5401v5410-2022-10-24)[Compare Source](typescript-eslint/typescript-eslint@v5.40.1...v5.41.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.40.1](typescript-eslint/typescript-eslint@v5.40.0...v5.40.1) (2022-10-17)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMy4xLjAiLCJ1cGRhdGVkSW5WZXIiOiIzMy4xLjAifQ==-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1604Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

sync-by-unitobot mentioned this pull request

Nov 1, 2022

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.36.1 to 5.42.0numbersprotocol/capture-lite#2265

Closed

github-actionsbot locked asresolvedand limited conversation to collaborators

Nov 17, 2022

Labels

bug

Something isn't working

3 participants

Movatterモバイル変換

Uh oh!

fix(type-utils): prevent stack overflow inisTypeReadonly#5860

fix(type-utils): prevent stack overflow inisTypeReadonly#5860

Uh oh!

Conversation

sviat9440 commentedOct 23, 2022

PR Checklist

Uh oh!

nx-cloudbot commentedOct 23, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

typescript-eslintbot commentedOct 23, 2022

Uh oh!

netlifybot commentedOct 23, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

codecovbot commentedOct 23, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sviat9440 commentedOct 24, 2022

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg commentedOct 24, 2022

Uh oh!

JoshuaKGoldberg commentedOct 24, 2022

Uh oh!

sviat9440 commentedOct 24, 2022

Uh oh!

Uh oh!

fix(type-utils): prevent stack overflow in`isTypeReadonly`#5860

fix(type-utils): prevent stack overflow in`isTypeReadonly`#5860

nx-cloudbot commentedOct 23, 2022•
edited
Loading

netlifybot commentedOct 23, 2022•
edited
Loading

codecovbot commentedOct 23, 2022•
edited
Loading