typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(eslint-plugin): [member-ordering] support private fields#5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 2 commits intotypescript-eslint:mainfromMillerSvt:fix/4182

Nov 25, 2022

Merged

fix(eslint-plugin): [member-ordering] support private fields#5859

bradzacher merged 2 commits intotypescript-eslint:mainfromMillerSvt:fix/4182

Nov 25, 2022

Conversation

Copy link

Contributor

sviat9440 commentedOct 23, 2022

PR Checklist

Addresses an existing open issue:fixes[member-ordering] support private fields #4182
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Copy link

nx-cloudbot commentedOct 23, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4576c26. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedOct 23, 2022

Thanks for the PR,@sviat9440!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedOct 23, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4576c26`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/637efbb1be4a2c000806ef5a
😎 Deploy Preview	https://deploy-preview-5859--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedOct 23, 2022•
edited
Loading

Codecov Report

Merging#5859 (4576c26) intomain (53671d3) willincrease coverage by0.00%.
The diff coverage is95.83%.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #5859   +/-   ##=======================================  Coverage   91.28%   91.28%           =======================================  Files         366      366             Lines       12353    12365   +12       Branches     3611     3616    +5     =======================================+ Hits        11276    11287   +11  Misses        768      768- Partials      309      310    +1

Flag	Coverage Δ
unittest	`91.28% <95.83%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts	`95.39% <95.83%> (-0.32%)`	⬇️

bradzacher requested changes

Oct 23, 2022

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR!
Not a full review, just a quick glance

packages/eslint-plugin/src/rules/member-ordering.ts OutdatedShow resolvedHide resolved

bradzacher changed the title~~fix(eslint-plugin): Support private fields (#4182)~~fix(eslint-plugin): [member-ordering] support private fields

Oct 23, 2022

bradzacher added the enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule label

Oct 23, 2022

sviat9440 force-pushed thefix/4182 branch fromaab2866 to0185dc8Compare

October 23, 2022 19:24

sviat9440 marked this pull request as draft

October 24, 2022 07:46

fix(eslint-plugin): Support private fields (typescript-eslint#4182)

10ff764

sviat9440 force-pushed thefix/4182 branch from0185dc8 to10ff764Compare

October 24, 2022 09:56

sviat9440 requested a review frombradzacher

October 24, 2022 09:56

sviat9440 marked this pull request as ready for review

October 24, 2022 09:56

Copy link

ContributorAuthor

sviat9440 commentedOct 26, 2022

@bradzacher

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 18, 2022

Copy link

ContributorAuthor

sviat9440 commentedNov 21, 2022

@JoshuaKGoldberg the response to what do you expect?

Copy link

Member

JoshuaKGoldberg commentedNov 21, 2022

There's an open thread 🙂#5859 (comment)

JoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 23, 2022

bradzacher previously approved these changes

Nov 23, 2022

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is looking good to me!
thanks for adding this!

packages/eslint-plugin/src/rules/member-ordering.ts

		}
		// Only class instance fields, methods, get and set can have decorators attached to them
		if(
		accessibility!=='#private'&&

Copy link

Member

bradzacherNov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TIL you can't add decorators to#private members.

Copy link

ContributorAuthor

sviat9440Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can create an issue to support decorators from TypeScript 5.

Copy link

Member

bradzacher commentedNov 23, 2022

If you resolve the merge conflict then we can get this in!

bradzacher added awaiting response

Issues waiting for a reply from the OP or another party

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels

Nov 23, 2022

Merge branch 'master'

4576c26

sviat9440 dismissedbradzacher’sstale review via4576c26

November 24, 2022 05:05

Copy link

ContributorAuthor

sviat9440 commentedNov 24, 2022

resolved

bradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 25, 2022

bradzacher approved these changes

Nov 25, 2022

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

bradzacher merged commitf02761a intotypescript-eslint:main

Nov 25, 2022

JoshuaKGoldberg pushed a commit to JoshuaKGoldberg/typescript-eslint that referenced this pull request

Nov 25, 2022

fix(eslint-plugin): [member-ordering] support private fields (typescr…

e3ef2ba

…ipt-eslint#5859)Co-authored-by: Святослав Зайцев <sz@agentapp.ru>

rostislav-simonik mentioned this pull request

Dec 1, 2022

@typescript-eslint/eslint-plugin features to consider (rolling issue)mightyiam/eslint-config-love#665

Open

YusukeHirao pushed a commit to YusukeHirao/markuplint that referenced this pull request

Dec 1, 2022

Remove member-ordering set according to updated.

7052ae1

@seetypescript-eslint/typescript-eslint#5859_____

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 3, 2022

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

enhancement: plugin rule option

New rule option for an existing eslint-plugin rule

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [member-ordering] support private fields#5859

fix(eslint-plugin): [member-ordering] support private fields#5859

Uh oh!

Conversation

sviat9440 commentedOct 23, 2022

PR Checklist

Uh oh!

nx-cloudbot commentedOct 23, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

typescript-eslintbot commentedOct 23, 2022

Uh oh!

netlifybot commentedOct 23, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

codecovbot commentedOct 23, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sviat9440 commentedOct 26, 2022

Uh oh!

sviat9440 commentedNov 21, 2022

Uh oh!

JoshuaKGoldberg commentedNov 21, 2022

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

bradzacherNov 23, 2022

Choose a reason for hiding this comment

Uh oh!

sviat9440Nov 24, 2022

Choose a reason for hiding this comment

Uh oh!

bradzacher commentedNov 23, 2022

Uh oh!

sviat9440 commentedNov 24, 2022

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nx-cloudbot commentedOct 23, 2022•
edited
Loading

netlifybot commentedOct 23, 2022•
edited
Loading

codecovbot commentedOct 23, 2022•
edited
Loading