typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): add no-unsafe-declaration-merging#5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfromyeonjuan:fix/#5275

Oct 19, 2022

Merged

feat(eslint-plugin): add no-unsafe-declaration-merging#5840

JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfromyeonjuan:fix/#5275

Oct 19, 2022

Conversation

Copy link

Contributor

yeonjuan commentedOct 17, 2022

PR Checklist

Addresses an existing open issue:fixesNew Rule: ban unsafe declaration merging #5275
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

feat(eslint-plugin): add no-unsafe-declaration-merging

1417919

Copy link

Contributor

typescript-eslintbot commentedOct 17, 2022

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

nx-cloudbot commentedOct 17, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9be6acc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedOct 17, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`9be6acc`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/634f675dc1e123000828174a
😎 Deploy Preview	https://deploy-preview-5840--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedOct 17, 2022•
edited
Loading

Codecov Report

Merging#5840 (944a5a4) intomain (0be356b) willincrease coverage by0.00%.
The diff coverage is92.85%.

❗ Current head944a5a4 differs from pull request most recent head9be6acc. Consider uploading reports for the commit9be6acc to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@##             main    #5840   +/-   ##=======================================  Coverage   91.34%   91.35%           =======================================  Files         360      361    +1       Lines       12010    12024   +14       Branches     3498     3499    +1     =======================================+ Hits        10971    10984   +13  Misses        743      743- Partials      296      297    +1

Flag	Coverage Δ
unittest	`91.35% <92.85%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...-plugin/src/rules/no-unsafe-declaration-merging.ts	`92.85% <92.85%> (ø)`

JoshuaKGoldberg requested changes

Oct 17, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thanks for sending this in! Mostly requesting a bit more test coverage.

packages/eslint-plugin/docs/rules/no-unsafe-declaration-merging.md OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-unsafe-declaration-merging.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-unsafe-declaration-merging.test.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-unsafe-declaration-merging.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-unsafe-declaration-merging.test.tsShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 17, 2022

Apply reviews

28560e0

Copy link

ContributorAuthor

yeonjuan commentedOct 18, 2022•
edited
Loading

@JoshuaKGoldberg Thanks for the reviews. I fixed it.

And, I changed the reported node with the Identifier node, because reporting the whole class or interface declaration can overlap other errors inside the declaration body.

// fromcontext.report({node:node.parent,// class or interface declaration nodemessageId:'unsafeMerging',});// tocontext.report({node:node,// identifier nodemessageId:'unsafeMerging',});

yeonjuan requested a review fromJoshuaKGoldberg

October 18, 2022 12:22

fix

944a5a4

JoshuaKGoldberg previously approved these changes

Oct 19, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fantastic, thanks for sending this in@yeonjuan! 🙌

packages/eslint-plugin/docs/rules/no-unsafe-declaration-merging.md OutdatedShow resolvedHide resolved

JoshuaKGoldberg dismissed theirstale review via231ff6f

October 19, 2022 02:55

JoshuaKGoldberg added2 commits

October 18, 2022 22:55

Apply suggestions from code review

231ff6f

Merge branch 'main' into fix/typescript-eslint#5275

9be6acc

JoshuaKGoldberg approved these changes

Oct 19, 2022

View reviewed changes

JoshuaKGoldbergenabled auto-merge (squash)

October 19, 2022 02:56

JoshuaKGoldberg merged commit3728031 intotypescript-eslint:main

Oct 19, 2022

bradzacher reviewed

Oct 19, 2022

View reviewed changes

packages/eslint-plugin/docs/rules/no-unsafe-declaration-merging.md

		TypeScript's "declaration merging" supports merging separate declarations with the same name.

		Declaration merging between classes and interfaces is unsafe.
		The TypeScript compiler doesn't check whether properties are initialized, which can cause lead to TypeScript not detecting code that will cause runtime errors.

Copy link

Member

bradzacherOct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oops typo!

Suggested change

	The TypeScript compiler doesn't check whether properties are initialized, which cancauselead to TypeScript not detecting code that will cause runtime errors.
	The TypeScript compiler doesn't check whether properties are initialized, which can lead to TypeScript not detecting code that will cause runtime errors.

packages/eslint-plugin/src/rules/no-unsafe-declaration-merging.ts

		docs: {
		description: 'Disallow unsafe declaration merging',
		recommended: 'strict',
		requiresTypeChecking: true,

Copy link

Member

bradzacherOct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should actually be able to do this without type info and just with the scope analysis APIs.

playground

You can see that if the names clash, then we can iterate through thevariable.defs array and do a similar comparison as you've done here -variable.defs.some(def => def.node.type === unsafeType) where
unsafeType == AST_NODE_TYPES.TSInterfaceDeclaration | AST_NODE_TYPES.ClassDeclaration

Copy link

Member

JoshuaKGoldbergOct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, I should finally get familiar with the scope manager 😄.#5854

Copy link

Member

JoshuaKGoldbergOct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@yeonjuan do you have time to tackle this soon? I can if not, no worries 😄

Copy link

ContributorAuthor

yeonjuanOct 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@bradzacher,@JoshuaKGoldberg I can fix this soon. I'll make a PR for it. (includingfixing typo)
Thanks!

JoshuaKGoldberg mentioned this pull request

Oct 20, 2022

Enhancement: [no-unsafe-declaration-merging] Switch to scope manager#5854

Closed

4 tasks

sync-by-unitobot mentioned this pull request

Oct 25, 2022

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.36.1 to 5.41.0numbersprotocol/capture-lite#2211

Closed

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

Oct 25, 2022

Update typescript-eslint monorepo to v5.41.0 (#1604)

659bcaa

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.40.1` -> `5.41.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.40.1/5.41.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.40.1` -> `5.41.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.40.1/5.41.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5410-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5401v5410-2022-10-24)[Compare Source](typescript-eslint/typescript-eslint@v5.40.1...v5.41.0)##### Bug Fixes-   **eslint-plugin:** \[no-base-to-string] ignore Error, URL, and URLSearchParams by default ([#&#8203;5839](typescript-eslint/typescript-eslint#5839)) ([96e1c6c](typescript-eslint/typescript-eslint@96e1c6c))-   **type-utils:** prevent stack overflow in `isTypeReadonly` ([#&#8203;5860](typescript-eslint/typescript-eslint#5860)) ([a6d8f7e](typescript-eslint/typescript-eslint@a6d8f7e)), closes [#&#8203;4476](typescript-eslint/typescript-eslint#4476)##### Features-   **eslint-plugin:** \[no-unsafe-declaration-merging] switch to use scope analysis instead of type information ([#&#8203;5865](typescript-eslint/typescript-eslint#5865)) ([e70a10a](typescript-eslint/typescript-eslint@e70a10a))-   **eslint-plugin:** add no-unsafe-declaration-merging ([#&#8203;5840](typescript-eslint/typescript-eslint#5840)) ([3728031](typescript-eslint/typescript-eslint@3728031))#### [5.40.1](typescript-eslint/typescript-eslint@v5.40.0...v5.40.1) (2022-10-17)##### Bug Fixes-   **eslint-plugin:** Skip missing 'rest' tuple type arguments in no-misused-promises ([#&#8203;5809](typescript-eslint/typescript-eslint#5809)) ([c5beaa2](typescript-eslint/typescript-eslint@c5beaa2)), closes [#&#8203;5807](typescript-eslint/typescript-eslint#5807)</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5410-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5401v5410-2022-10-24)[Compare Source](typescript-eslint/typescript-eslint@v5.40.1...v5.41.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.40.1](typescript-eslint/typescript-eslint@v5.40.0...v5.40.1) (2022-10-17)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMy4xLjAiLCJ1cGRhdGVkSW5WZXIiOiIzMy4xLjAifQ==-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1604Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

sync-by-unitobot mentioned this pull request

Nov 1, 2022

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.36.1 to 5.42.0numbersprotocol/capture-lite#2265

Closed

github-actionsbot locked asresolvedand limited conversation to collaborators

Nov 17, 2022

Labels

awaiting response

Issues waiting for a reply from the OP or another party

3 participants

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): add no-unsafe-declaration-merging#5840

feat(eslint-plugin): add no-unsafe-declaration-merging#5840

Uh oh!

Conversation

yeonjuan commentedOct 17, 2022

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedOct 17, 2022

Uh oh!

nx-cloudbot commentedOct 17, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

netlifybot commentedOct 17, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

codecovbot commentedOct 17, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yeonjuan commentedOct 18, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bradzacherOct 19, 2022

Choose a reason for hiding this comment

Uh oh!

bradzacherOct 19, 2022

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergOct 20, 2022

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergOct 20, 2022

Choose a reason for hiding this comment

Uh oh!

yeonjuanOct 22, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nx-cloudbot commentedOct 17, 2022•
edited
Loading

netlifybot commentedOct 17, 2022•
edited
Loading

codecovbot commentedOct 17, 2022•
edited
Loading

yeonjuan commentedOct 18, 2022•
edited
Loading