RemovedforceSuggestionFixer from the code since the ruleprefer-nullish-coalescing is notfixable anymore, i.e, it won't fix automatically on someone running--fix. Which makes this option useless.

removed forceSuggestionFixer option since it is not being used anymore.

65c72b9

Copy link

nx-cloudbot commentedOct 16, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit65c72b9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 24 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedOct 16, 2022

Thanks for the PR,@adnanhashmi09!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedOct 16, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`65c72b9`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/634c026e2094c1000852888d
😎 Deploy Preview	https://deploy-preview-5835--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

ContributorAuthor

adnanhashmi09 commentedOct 16, 2022

@JoshuaKGoldberg Please review the PR. Some of the tests are failing, but when I run the tests locallyyarn test they pass without any problem.

JoshuaKGoldberg approved these changes

Oct 16, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perfect, thanks!

JoshuaKGoldbergenabled auto-merge (squash)

October 16, 2022 20:21

Copy link

codecovbot commentedOct 24, 2022•
edited
Loading

Codecov Report

Merging#5835 (65c72b9) intomain (da597c7) willincrease coverage by2.63%.
The diff coverage isn/a.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #5835      +/-   ##==========================================+ Coverage   91.34%   93.98%   +2.63%==========================================  Files         360      148     -212       Lines       12010     8083    -3927       Branches     3498     2664     -834     ==========================================- Hits        10971     7597    -3374+ Misses        743      273     -470+ Partials      296      213      -83

Flag	Coverage Δ
unittest	`93.98% <ø> (+2.63%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`100.00% <ø> (ø)`
packages/scope-manager/src/lib/scripthost.ts
packages/utils/src/ts-eslint/SourceCode.ts
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts
packages/scope-manager/src/lib/esnext.symbol.ts
packages/scope-manager/src/referencer/Reference.ts
packages/utils/src/ast-utils/misc.ts
...ages/scope-manager/src/lib/es2018.asynciterable.ts
...ges/scope-manager/src/definition/TypeDefinition.ts
packages/utils/src/ts-eslint-scope/index.ts
... and203 more