#5750 added a dependency onsemver to the@typescript-eslint/utils package. This implicitly depended on@types/semver which is provided by the top-level workspace package.json file but not@typescript-eslint/utils itself. This caused my application to break.

My application imports some types from this package:

importtype{TSESLint,JSONSchema}from'@typescript-eslint/utils';

And the breakage occurred during:

While running:

> tscError: node_modules/@typescript-eslint/utils/dist/eslint-utils/rule-tester/dependencyConstraints.d.ts(1,25):error TS7016: Could not find a declaration file for module 'semver'.'/home/runner/work/eslint-doc-generator/eslint-doc-generator/node_modules/@typescript-eslint/utils/node_modules/semver/index.js' implicitly has an 'any' type.

I have fixed the issue by adding the missing dependency.

In this PR or as a follow-up, we should also remove@types/semver from the top-level package.json which doesn't need it, and instead ensure it's defined as an explicit dependency in each package that uses it.

fix(utils): add missing dependency on @types/semver

5e9d356

Copy link

nx-cloudbot commentedOct 14, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5e9d356. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedOct 14, 2022

Thanks for the PR,@bmish!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedOct 14, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`5e9d356`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6348c4c1384622000825835f
😎 Deploy Preview	https://deploy-preview-5825--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

codecovbot commentedOct 14, 2022•
edited
Loading

Codecov Report

Merging#5825 (5e9d356) intomain (9ffdb05) willdecrease coverage by2.47%.
The diff coverage isn/a.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #5825      +/-   ##==========================================- Coverage   93.82%   91.34%   -2.48%==========================================  Files         134      360     +226       Lines        1506    12010   +10504       Branches      226     3498    +3272     ==========================================+ Hits         1413    10971    +9558- Misses         60      743     +683- Partials       33      296     +263

Flag	Coverage Δ
unittest	`91.34% <ø> (-2.48%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/utils/src/ts-eslint/ParserOptions.ts	`20.00% <0.00%> (ø)`
...lugin/src/rules/no-confusing-non-null-assertion.ts	`82.60% <0.00%> (ø)`
...-plugin/src/rules/no-unnecessary-type-assertion.ts	`94.66% <0.00%> (ø)`
packages/eslint-plugin/src/rules/semi.ts	`92.85% <0.00%> (ø)`
...ckages/eslint-plugin/src/rules/no-throw-literal.ts	`97.67% <0.00%> (ø)`
...nt-plugin/src/rules/lines-between-class-members.ts	`92.85% <0.00%> (ø)`
...kages/eslint-plugin/src/rules/init-declarations.ts	`100.00% <0.00%> (ø)`
packages/eslint-plugin-tslint/src/rules/config.ts	`97.29% <0.00%> (ø)`
.../src/rules/sort-type-union-intersection-members.ts	`90.74% <0.00%> (ø)`
packages/utils/src/ts-eslint/Scope.ts	`80.00% <0.00%> (ø)`
... and216 more