Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-estree): clarify docs and error for program project without matching TSConfig#5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedOct 7, 2022•
edited
Loading

PR Checklist

Overview

This PR does three things:

  • It changes the error message from@typescript-eslint/typescript-estree -as called by@typescript-eslint/parser whenparserOptions.program is specified but no TSConfig includes the file being linted. Now, the error message is much more clear on what's going on, and what some suggested remediations & further docs reading are
  • It clarifies & expands the initial context mentioned in the docs
  • It moves those docs from Typed Linting FAQs to the general troubleshooting page
    • I'm not 100% on this, and might be changing my opinion from several months ago... but my current hunch is that it'd be good to have all FAQs in one place

@nx-cloud
Copy link

nx-cloudbot commentedOct 7, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit73e875f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedOct 7, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit73e875f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/635703b0652449000800d91f
😎 Deploy Previewhttps://deploy-preview-5762--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedOct 7, 2022•
edited
Loading

Codecov Report

Merging#5762 (def07d6) intomain (1eaae09) willdecrease coverage by0.00%.
The diff coverage is90.90%.

❗ Current headdef07d6 differs from pull request most recent head73e875f. Consider uploading reports for the commit73e875f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##             main    #5762      +/-   ##==========================================- Coverage   91.33%   91.32%   -0.01%==========================================  Files         361      361                Lines       12033    12041       +8       Branches     3503     3506       +3     ==========================================+ Hits        10990    10997       +7- Misses        747      748       +1  Partials      296      296
FlagCoverage Δ
unittest91.32% <90.90%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...-estree/src/create-program/createProjectProgram.ts93.47% <90.90%> (-0.81%)⬇️
...ackages/eslint-plugin/src/rules/member-ordering.ts95.62% <0.00%> (-0.10%)⬇️

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewOctober 7, 2022 02:26
Copy link
Contributor

@a-churchilla-churchill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As an end user I think the updated error message + associated docs are very helpful!

JoshuaKGoldberg reacted with heart emoji
Co-authored-by: Andrew Churchill <chu.andrew.8@gmail.com>
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not a full review, just a few comments

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

summore comments! Looking good!

@bradzacherbradzacher added awaiting responseIssues waiting for a reply from the OP or another party enhancementNew feature or request labelsOct 24, 2022
JoshuaKGoldbergand others added2 commitsOctober 24, 2022 13:58
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelOct 24, 2022
## I get errors telling me "The file must be included in at least one of the projects provided"
## I get errors telling me "ESLint was configured to run ... However, that TSConfig does not / none of those TSConfigs include this file"

### Fixing the Error
Copy link
MemberAuthor

@JoshuaKGoldbergJoshuaKGoldbergOct 24, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I split this section into these two h3s. Re-reading the un-split explanation felt like a tl;dr. My instinct is users just want to know how to fix this ASAP.

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

image

JoshuaKGoldberg reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)October 24, 2022 21:29
@JoshuaKGoldbergJoshuaKGoldberg merged commit67744db intotypescript-eslint:mainOct 24, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@a-churchilla-churchilla-churchill left review comments

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
No open projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Improve error message & docs for "The file does not match your project config"
3 participants
@JoshuaKGoldberg@bradzacher@a-churchill
[8]ページ先頭
©2009-2025 Movatter.jp