Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): add details to Configurations page#5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Reworks theConfigurations page to emphasize the recommended configs. Also mention theall andbase configs alongsideeslint-recommended as "other" (utility) configs, and adds the Prettified, stringified contents of each config to the page.

@nx-cloud
Copy link

nx-cloudbot commentedOct 3, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit473794e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedOct 3, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit473794e
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6356e6c8981ddb0008e05b25
😎 Deploy Previewhttps://deploy-preview-5719--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewOctober 16, 2022 02:50
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like the build is failing.

[!] Error: 'Linter' is not exported by ../../node_modules/eslint/lib/api.js, imported by src/linter/linter.jshttps://rollupjs.org/guide/en/#error-name-is-not-exported-by-modulesrc/linter/linter.js (2:0)1: import 'vs/language/typescript/tsWorker';2: import { Linter } from 'eslint';   ^3: import rules from '@typescript-eslint/eslint-plugin/dist/rules';Error: 'Linter' is not exported by ../../node_modules/eslint/lib/api.js, imported by src/linter/linter.js    at error (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:198:30)    at Module.error (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:12560:16)    at Module.traceVariable (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:12919:29)    at ModuleScope.findVariable (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:11571:39)    at FunctionScope.findVariable (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:6503:38)    at ChildScope.findVariable (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:6503:38)    at Identifier.bind (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:7570:40)    at NewExpression.bind (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:5400:23)    at VariableDeclarator.bind (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:5400:23)    at VariableDeclaration.bind (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:5396:73)

Something in this PR has introduced the error I think cos it's not broken onmain

@bradzacherbradzacher added awaiting responseIssues waiting for a reply from the OP or another party documentationDocumentation ("docs") that needs adding/updating labelsOct 24, 2022
@JoshuaKGoldberg
Copy link
MemberAuthor

Grr, I was really hoping that config was from some kind of caching issue.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftOctober 24, 2022 19:15
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewOctober 24, 2022 19:26
@JoshuaKGoldbergJoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party labelOct 26, 2022
@bradzacherbradzacher merged commitc4ba387 intotypescript-eslint:mainNov 23, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the docs-configs-details branchNovember 24, 2022 02:36
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

documentationDocumentation ("docs") that needs adding/updating

Projects

No open projects
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Add pages for the contents of configurations to the website?

2 participants

@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp