Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support parsingsatisfies operators#5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzukisosukesuzuki commentedOct 2, 2022•
edited by bradzacher
Loading

PR Checklist

Overview

Based on#5716
Adds parsing support forsatisfies operator.

kachick reacted with heart emoji
@nx-cloud
Copy link

nx-cloudbot commentedOct 2, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5419dea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedOct 2, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5419dea
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6376cf6ce6dcb20008cf4637
😎 Deploy Previewhttps://deploy-preview-5717--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@sosukesuzukisosukesuzukiforce-pushed thesupport-satisfies-operators branch fromd60f18b to3f346d6CompareOctober 2, 2022 17:07
@codecov
Copy link

codecovbot commentedOct 2, 2022•
edited
Loading

Codecov Report

Merging#5717 (94fbc45) intomain (a40a311) willincrease coverage by0.00%.
The diff coverage is100.00%.

❗ Current head94fbc45 differs from pull request most recent head5419dea. Consider uploading reports for the commit5419dea to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@##             main    #5717   +/-   ##=======================================  Coverage   91.29%   91.29%           =======================================  Files         366      366             Lines       12347    12348    +1       Branches     3610     3610           =======================================+ Hits        11272    11273    +1  Misses        767      767             Partials      308      308
FlagCoverage Δ
unittest91.29% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/visitor-keys/src/visitor-keys.ts100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts97.89% <100.00%> (+<0.01%)⬆️

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewNovember 17, 2022 17:35
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for doing this!

thankss

For reference, changes I made prior to merging:

  • update babel packages so it supports the satisfies operator
  • converted the fixture test from a "shared fixtures" test to a new and shiny "ast-spec" test.
    • this is the preferred way of doing these ast tests going forward as we can more easily split them, compare with babel etc

JoshuaKGoldberg, sosukesuzuki, and kachick reacted with thumbs up emoji
@bradzacherbradzacherenabled auto-merge (squash)November 18, 2022 00:32
@bradzacherbradzacher merged commit20d7cae intotypescript-eslint:mainNov 18, 2022
@sosukesuzukisosukesuzuki deleted the support-satisfies-operators branchNovember 20, 2022 04:30
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull requestNov 23, 2022
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sosukesuzuki@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp