Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: update to TypeScript 4.9#5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzukisosukesuzuki commentedOct 2, 2022•
edited
Loading

We need to wait that RC version is released

PR Checklist

Overview

  • Installtypescript@4.9.1-beta
  • Update the patch file for 4.9.1-beta
  • Rungenerate:lib

shirotech, jleider, and Finesse reacted with thumbs up emojishirotech reacted with hooray emojishirotech and jrolfs reacted with heart emojishirotech and jrolfs reacted with rocket emoji
@nx-cloud
Copy link

nx-cloudbot commentedOct 2, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit35809e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedOct 2, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit35809e3
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63629f3d2319200008b79176
😎 Deploy Previewhttps://deploy-preview-5716--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

package.json Outdated
"typescript": "~4.8.3",
"@types/node": "^17.0.31",
"typescript": "~4.9.1-beta",
"@types/node": "^18.7.23",

This comment was marked as resolved.

@codecov
Copy link

codecovbot commentedOct 2, 2022•
edited
Loading

Codecov Report

Merging#5716 (35809e3) intomain (f11183c) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #5716   +/-   ##=======================================  Coverage   91.29%   91.30%           =======================================  Files         365      366    +1       Lines       12251    12255    +4       Branches     3577     3577           =======================================+ Hits        11185    11189    +4  Misses        758      758             Partials      308      308
FlagCoverage Δ
unittest91.30% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/scope-manager/src/lib/dom.ts100.00% <ø> (ø)
packages/scope-manager/src/lib/webworker.ts100.00% <ø> (ø)
packages/scope-manager/src/lib/es2019.intl.ts100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2019.ts100.00% <100.00%> (ø)
packages/scope-manager/src/lib/index.ts100.00% <100.00%> (ø)
...ackages/scope-manager/src/referencer/Referencer.ts95.96% <100.00%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts93.33% <100.00%> (ø)

@sosukesuzukisosukesuzuki changed the titlefeat: Update to TypeScript 4.9feat: update to TypeScript 4.9Oct 2, 2022
@kasperpeulen
Copy link

We need to wait that RC version is released

It has landedhttps://devblogs.microsoft.com/typescript/announcing-typescript-4-9-rc/ 🎉

JoshuaKGoldberg reacted with hooray emoji

@sosukesuzukisosukesuzuki marked this pull request as ready for reviewNovember 2, 2022 17:26
@sosukesuzuki
Copy link
ContributorAuthor

@bradzacher@JoshuaKGoldberg This PR is ready for review!

JoshuaKGoldberg, kasperpeulen, outerlook, and rzyns reacted with hooray emoji

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks great to me, thanks!

I'm not 100% familiar with how these are generated so I'll defer to@bradzacher

sosukesuzuki reacted with thumbs up emoji
@ngregory-rbi
Copy link

Given the final version of 4.9 is to release today, should we expect this to be merged and released anytime soon?

kasperpeulen, jalandis, and gkiely reacted with eyes emoji

@kasperpeulen
Copy link

It would be great if we can test this already in a canary version.

@ngregory-rbi
Copy link

It would be great if we can test this already in a canary version.

Not sure which would be a canary, but there the4.9.1-beta and the4.9.2-rc.

@bradzacher
Copy link
Member

Please follow along at the issue#5688 for status of support for TS4.9.
This PR is just about locally upgrading our package.

@shirotech

This comment was marked as spam.

@bradzacherbradzacher merged commit4d744ea intotypescript-eslint:mainNov 17, 2022
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull requestNov 23, 2022
* feat: update typescript to 4.9.1* fix: add patch file for 4.9.1-beta* feat(typescript-estree): update version range* feat: run `generate-lib` script* chore: update patch for typescript* fix: run `lint-fix`* feat: update to typescript 4.9.2-rc* chore: run patch-package* chore: update `@types/node`
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ArnaudBarreArnaudBarreArnaudBarre left review comments

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@sosukesuzuki@kasperpeulen@ngregory-rbi@bradzacher@shirotech@JoshuaKGoldberg@ArnaudBarre
[8]ページ先頭
©2009-2025 Movatter.jp