typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): [ban-ts-comment] counts graphemes instead of`String.prototype.length`#5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 9 commits intotypescript-eslint:mainfromsosukesuzuki:fix-5678

Jan 24, 2023

Merged

fix(eslint-plugin): [ban-ts-comment] counts graphemes instead of`String.prototype.length`#5704

JoshuaKGoldberg merged 9 commits intotypescript-eslint:mainfromsosukesuzuki:fix-5678

Jan 24, 2023

Conversation

Copy link

Contributor

sosukesuzuki commentedOct 1, 2022

PR Checklist

Addresses an existing open issue:fixesBug: [ts-ban-comment] doesn't report error for a description includes with multiple code units #5678
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Counts graphemes instead ofString.prototype.length (code units).

FYI ESLintid-length rule has been fixed for similar bug:eslint/eslint#16321

fix: counts graphemes instead of String length

d0b2ecd

Copy link

Contributor

typescript-eslintbot commentedOct 1, 2022

Thanks for the PR,@sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

nx-cloudbot commentedOct 1, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf17c78f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedOct 1, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f17c78f`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63d05ed449544c0009033f09
😎 Deploy Preview	https://deploy-preview-5704--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JoshuaKGoldberg requested changes

Oct 1, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks for sending this in so quickly! Just asking for another test case.

packages/eslint-plugin/src/rules/ban-ts-comment.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/ban-ts-comment.test.tsShow resolvedHide resolved

JoshuaKGoldberg reviewed

Oct 1, 2022

View reviewed changes

yarn.lockShow resolvedHide resolved

Copy link

codecovbot commentedOct 1, 2022•
edited
Loading

Codecov Report

Merging#5704 (814b429) intomain (47074b0) willincrease coverage by0.00%.
The diff coverage is100.00%.

❗ Current head814b429 differs from pull request most recent headf17c78f. Consider uploading reports for the commitf17c78f to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@##             main    #5704   +/-   ##=======================================  Coverage   91.27%   91.27%           =======================================  Files         366      366             Lines       12447    12453    +6       Branches     3646     3648    +2     =======================================+ Hits        11361    11367    +6  Misses        772      772             Partials      314      314

Flag	Coverage Δ
unittest	`91.27% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts	`97.43% <100.00%> (+0.46%)`	⬆️

sosukesuzukiand others added2 commits

October 2, 2022 16:59

Update packages/eslint-plugin/src/rules/ban-ts-comment.ts

4654850

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

chore: add valid tests

3d53073

JoshuaKGoldberg previously approved these changes

Oct 4, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks@sosukesuzuki!

Merge branch 'main' into fix-5678

4328f83

JoshuaKGoldbergenabled auto-merge (squash)

October 4, 2022 06:48

JoshuaKGoldberg changed the title~~fix:ban-ts-comment counts graphemes instead ofString.prototype.length~~fix(eslint-plugin):ban-ts-comment counts graphemes instead ofString.prototype.length

Oct 4, 2022

bradzacher reviewed

Oct 4, 2022

View reviewed changes

packages/eslint-plugin/package.jsonShow resolvedHide resolved

bradzacher previously requested changes

Oct 4, 2022

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rc for above comment

bradzacher added the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 4, 2022

Copy link

Member

JoshuaKGoldberg commentedNov 16, 2022

👋 Hey@sosukesuzuki! Just checking in, is this still something you have time for? No worries if not - I just don't want to leave it hanging.

Merge branch 'main'

788464e

JoshuaKGoldberg dismissed theirstale review via788464e

December 18, 2022 23:03

JoshuaKGoldberg changed the title~~fix(eslint-plugin):ban-ts-comment counts graphemes instead ofString.prototype.length~~fix(eslint-plugin): [ban-ts-comment] counts graphemes instead ofString.prototype.length

Dec 19, 2022

Add grapheme-splitter to peerDependencies

64122ed

JoshuaKGoldberg marked this pull request as draft

December 19, 2022 02:11

auto-merge was automatically disabled

December 19, 2022 02:11

Pull request was converted to draft

Move to standard dependency

47a3e78

JoshuaKGoldberg marked this pull request as ready for review

December 20, 2022 00:02

JoshuaKGoldberg requested a review frombradzacher

December 21, 2022 01:07

Copy link

Member

JoshuaKGoldberg commentedJan 24, 2023

Chatted with@bradzacher - full dependency forgrapheme-splitter should be the way to go. :shipit: !

JoshuaKGoldberg added2 commits

January 24, 2023 17:36

Merge branch 'main' into fix-5678

814b429

No more peerDependency

f17c78f

JoshuaKGoldberg approved these changes

Jan 24, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚢

JoshuaKGoldberg dismissedbradzacher’sstale review

January 24, 2023 23:01

I did the thing

JoshuaKGoldberg merged commit09d57ce intotypescript-eslint:main

Jan 24, 2023

sosukesuzuki deleted the fix-5678 branch

January 27, 2023 16:49

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

Feb 2, 2023

Update typescript-eslint monorepo to v5.50.0 (#1757)

067929b

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.48.2` -> `5.50.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.48.2/5.50.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.48.2` -> `5.50.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.48.2/5.50.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.50.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5500-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5490v5500-2023-01-31)[Compare Source](typescript-eslint/typescript-eslint@v5.49.0...v5.50.0)##### Bug Fixes-   **eslint-plugin:** \[ban-ts-comment] counts graphemes instead of `String.prototype.length` ([#&#8203;5704](typescript-eslint/typescript-eslint#5704)) ([09d57ce](typescript-eslint/typescript-eslint@09d57ce))-   **eslint-plugin:** \[prefer-optional-chain] fix `ThisExpression` and `PrivateIdentifier` errors ([#&#8203;6028](typescript-eslint/typescript-eslint#6028)) ([85e783c](typescript-eslint/typescript-eslint@85e783c))-   **eslint-plugin:** \[prefer-optional-chain] fixer produces wrong logic ([#&#8203;5919](typescript-eslint/typescript-eslint#5919)) ([b0f6c8e](typescript-eslint/typescript-eslint@b0f6c8e)), closes [#&#8203;1438](typescript-eslint/typescript-eslint#1438)##### Features-   **eslint-plugin:** add `key-spacing` rule extension for interface & type declarations ([#&#8203;6211](typescript-eslint/typescript-eslint#6211)) ([67706e7](typescript-eslint/typescript-eslint@67706e7))### [`v5.49.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5490-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5482v5490-2023-01-23)[Compare Source](typescript-eslint/typescript-eslint@v5.48.2...v5.49.0)##### Features-   **eslint-plugin:** \[naming-convention] add support for `#private` modifier on class members ([#&#8203;6259](typescript-eslint/typescript-eslint#6259)) ([c8a6d80](typescript-eslint/typescript-eslint@c8a6d80))#### [5.48.2](typescript-eslint/typescript-eslint@v5.48.1...v5.48.2) (2023-01-16)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)#### [5.48.1](typescript-eslint/typescript-eslint@v5.48.0...v5.48.1) (2023-01-09)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.50.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5500-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5490v5500-2023-01-31)[Compare Source](typescript-eslint/typescript-eslint@v5.49.0...v5.50.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)### [`v5.49.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5490-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5482v5490-2023-01-23)[Compare Source](typescript-eslint/typescript-eslint@v5.48.2...v5.49.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.48.2](typescript-eslint/typescript-eslint@v5.48.1...v5.48.2) (2023-01-16)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.48.1](typescript-eslint/typescript-eslint@v5.48.0...v5.48.1) (2023-01-09)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTQuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS4yIn0=-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1757Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

github-actionsbot locked asresolvedand limited conversation to collaborators

Feb 4, 2023

Labels

awaiting response

Issues waiting for a reply from the OP or another party

3 participants

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [ban-ts-comment] counts graphemes instead ofString.prototype.length#5704

fix(eslint-plugin): [ban-ts-comment] counts graphemes instead ofString.prototype.length#5704

Uh oh!

Conversation

sosukesuzuki commentedOct 1, 2022

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedOct 1, 2022

Uh oh!

nx-cloudbot commentedOct 1, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

netlifybot commentedOct 1, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovbot commentedOct 1, 2022• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg commentedNov 16, 2022

Uh oh!

JoshuaKGoldberg commentedJan 24, 2023

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fix(eslint-plugin): [ban-ts-comment] counts graphemes instead of`String.prototype.length`#5704

fix(eslint-plugin): [ban-ts-comment] counts graphemes instead of`String.prototype.length`#5704

nx-cloudbot commentedOct 1, 2022•
edited
Loading

netlifybot commentedOct 1, 2022•
edited
Loading

codecovbot commentedOct 1, 2022•
edited
Loading