Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
WIP Integrate used tsutils functions#5689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nx-cloudbot commentedSep 25, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit4f1cbd7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 fromNxCloud. |
Thanks for the PR,@varwasabi! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
netlifybot commentedSep 25, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
❌ Deploy Preview fortypescript-eslint failed.
|
codecovbot commentedSep 25, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #5689 +/- ##========================================= Coverage 91.01% 91.02% ========================================= Files 365 348 -17 Lines 11962 10203 -1759 Branches 3483 3053 -430 =========================================- Hits 10887 9287 -1600+ Misses 781 657 -124+ Partials 294 259 -35
Flags with carried forward coverage won't be shown.Click here to find out more.
|
aaditmshah commentedOct 22, 2022
Any update on this PR? |
👋@varwasabi! I forked More explanation: I long term don't think we want to be in the business of maintaining a fork of If we were the only users of I'll note that#6428 is still in review right now and Cheers! |
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
To remove the dependency ontsutils the following used functions from that library need to be moved into the type-utils package:
This PR addresses that and removes any use oftsutils across all packages.