Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP Integrate used tsutils functions#5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

varwasabi
Copy link

@varwasabivarwasabi commentedSep 25, 2022
edited
Loading

PR Checklist

Overview

To remove the dependency ontsutils the following used functions from that library need to be moved into the type-utils package:

  • getWellKnownSymbolPropertyOfType
  • hasModifier
  • isAssignmentKind
  • isBinaryExpression
  • isBooleanLiteralType
  • isCallExpression
  • isCompilerOptionEnabled
  • isConditionalType
  • isIdentifier
  • isIntersectionType
  • isJsxExpression
  • isModifierFlagSet
  • isNewExpression
  • isObjectFlagSet
  • isObjectType
  • isParameterDeclaration
  • isPropertyAssignment
  • isPropertyDeclaration
  • isPropertyReadonlyInType
  • isStrictCompilerOptionEnabled
  • isSymbolFlagSet
  • isThenableType
  • isTypeFlagSet
  • isTypeReference
  • isUnionOrIntersectionType
  • isUnionType
  • isValidPropertyAccess
  • isVariableDeclaration
  • unionTypeParts

This PR addresses that and removes any use oftsutils across all packages.

@nx-cloud
Copy link

nx-cloudbot commentedSep 25, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4f1cbd7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx run-many --target=build --all --parallel --exclude website --exclude website

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@varwasabi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedSep 25, 2022
edited
Loading

Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commit4f1cbd7
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6333cb04e26b61000964d12b

@codecov
Copy link

codecovbot commentedSep 25, 2022
edited
Loading

Codecov Report

Merging#5689 (cffe5d3) intomain (84e316b) willincrease coverage by0.00%.
The diff coverage is55.43%.

❗ Current headcffe5d3 differs from pull request most recent head4f1cbd7. Consider uploading reports for the commit4f1cbd7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@##             main    #5689     +/-   ##=========================================  Coverage   91.01%   91.02%             =========================================  Files         365      348     -17       Lines       11962    10203   -1759       Branches     3483     3053    -430     =========================================- Hits        10887     9287   -1600+ Misses        781      657    -124+ Partials      294      259     -35
FlagCoverage Δ
unittest91.02% <55.43%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/type-utils/src/isNumericPropertyName.ts0.00% <0.00%> (ø)
...es/type-utils/src/isStrictCompilerOptionEnabled.ts0.00% <0.00%> (ø)
packages/type-utils/src/isThenableType.ts4.34% <4.34%> (ø)
...type-utils/src/getWellKnownSymbolPropertyOfType.ts6.66% <6.66%> (ø)
packages/type-utils/src/isValidPropertyAccess.ts7.14% <7.14%> (ø)
packages/type-utils/src/isInConstContext.ts8.69% <8.69%> (ø)
packages/type-utils/src/isCompilerOptionEnabled.ts10.00% <10.00%> (ø)
...ges/type-utils/src/isNumericOrStringLikeLiteral.ts20.00% <20.00%> (ø)
.../type-utils/src/isReadonlyAssignmentDeclaration.ts21.42% <21.42%> (ø)
packages/type-utils/src/isAssignmentKind.ts25.00% <25.00%> (ø)
... and131 more

@aaditmshah
Copy link

Any update on this PR?

@JoshuaKGoldberg
Copy link
Member

👋@varwasabi! I forkedtsutils intohttps://github.com/JoshuaKGoldberg/ts-api-tools and have a replacement PR here:#6428. We really appreciate your work on this PR, but don't think it's in our best interest to continue with it. Thanks so much - and I hope you work on more contributions for typescript-eslint! ❤️


More explanation: I long term don't think we want to be in the business of maintaining a fork of tsutilsin this repo.tsutils has a lot in it and we're already stretched pretty thin in this repository. This PR is over 1k lines added - which isn't ahuge amount of code, but still adds a cost.

If we were the only users oftsutils then it'd be pretty reasonable for us to just use it internally and/or as an addition to@typescript-eslint/type-utils. Buttsutils is used by a lot of folks. What'd be healthiest for its many consumers is to have a version of it that's actually updated & usable. Hence the hard fork tots-api-tools.


I'll note that#6428 is still in review right now andts-api-tools is very new. If it ends up that I'm wrong and we do want to maintain copies of the manytsutils functions inpackages/type-utils, then we can certainly reopen this PR - and I can help get it through.

Cheers!

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 14, 2023
@varwasabivarwasabi deleted the integrate-tsutils branchMarch 22, 2023 15:33
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: drop dependency on tsutils
3 participants
@varwasabi@aaditmshah@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp