Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): make playground code editor horizontally resizable#5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 7 commits intotypescript-eslint:mainfromyimothysu:website-playground-resize-editor
Sep 24, 2022
Merged

chore(website): make playground code editor horizontally resizable#5667

JoshuaKGoldberg merged 7 commits intotypescript-eslint:mainfromyimothysu:website-playground-resize-editor
Sep 24, 2022

Conversation

yimothysu
Copy link
Contributor

@yimothysuyimothysu commentedSep 17, 2022•
edited
Loading

PR Checklist

Overview

Adds horizontal resizing functionality via dragging for the code editor in the website Playground.
Clipboard01

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @jimsu2012!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedSep 17, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit643b5b0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedSep 17, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit643b5b0
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/632e2272f24d9b00088b717a
😎 Deploy Previewhttps://deploy-preview-5667--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@yimothysuyimothysu changed the titleMake editor horizontally resizablefeat(website): make playground code editor horizontally resizableSep 17, 2022
@bradzacherbradzacher changed the titlefeat(website): make playground code editor horizontally resizablechore(website): make playground code editor horizontally resizableSep 17, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A great start! 🚀

@yimothysu
Copy link
ContributorAuthor

The websites tests failing is unrelated to this change. The latest commit to main (78467fc) has the same error.

JoshuaKGoldberg reacted with thumbs up emoji

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is looking great, thanks! ✨

Just a couple bugs to fix up. Using aResizeObserver or similar would be swell but I'm fine to just file that as a cleanup for later.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelSep 20, 2022
@yimothysuyimothysu dismissed a stale review via95d27d7September 21, 2022 00:36
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks so much for sending this in & iterating on it @jimsu2012! 🙌

Just a couple of code reuse requests. I can tackle them myself if you don't have the time - lmk!

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 !

@JoshuaKGoldbergJoshuaKGoldberg merged commitb8e56a6 intotypescript-eslint:mainSep 24, 2022
@yimothysu
Copy link
ContributorAuthor

Awesome, excited to see this in prod!

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another partywebsite: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Allow resizing/collapsing panes
3 participants
@yimothysu@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp