Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): correct true extendsBaseRule values#5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromyokkkoso:fix/5621
Sep 13, 2022
Merged

chore(website): correct true extendsBaseRule values#5632

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromyokkkoso:fix/5621
Sep 13, 2022

Conversation

yokkkoso
Copy link
Contributor

@yokkkosoyokkkoso commentedSep 12, 2022
edited
Loading

PR Checklist

Overview

In#5621 I didn't notice that the value of extendsBaseRule could be boolean, so some rules on the site was changed totrue.

@nx-cloud
Copy link

nx-cloudbot commentedSep 12, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitb234b51. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yokkkoso!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedSep 12, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitb234b51
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/63206f737082f70009f6f8e0
😎 Deploy Previewhttps://deploy-preview-5632--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg changed the title fix(website): Fix #5621 bugchore(website): correct true extendsBaseRule valuesSep 13, 2022
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TIL also, thanks!

@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)September 13, 2022 11:54
@codecov
Copy link

codecovbot commentedSep 13, 2022
edited
Loading

Codecov Report

Merging#5632 (b234b51) intomain (009d564) willincrease coverage by0.03%.
The diff coverage isn/a.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #5632      +/-   ##==========================================+ Coverage   91.60%   91.63%   +0.03%==========================================  Files         369      134     -235       Lines       12394     1506   -10888       Branches     3614      226    -3388     ==========================================- Hits        11353     1380    -9973+ Misses        685       62     -623+ Partials      356       64     -292
FlagCoverage Δ
unittest91.63% <ø> (+0.03%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...lugin-internal/src/rules/plugin-test-formatting.ts
...lint-plugin/src/rules/prefer-nullish-coalescing.ts
...lugin/src/rules/prefer-readonly-parameter-types.ts
...-plugin/src/rules/naming-convention-utils/index.ts
...lugin/src/rules/consistent-indexed-object-style.ts
...ages/eslint-plugin/src/rules/no-empty-interface.ts
...lugin/src/rules/consistent-generic-constructors.ts
...kages/eslint-plugin/src/rules/naming-convention.ts
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts
packages/type-utils/src/getDeclaration.ts
... and225 more

@JoshuaKGoldbergJoshuaKGoldberg merged commit5487f9a intotypescript-eslint:mainSep 13, 2022
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@yokkkoso@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp