Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add .github/replies.yml#5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedSep 8, 2022
edited
Loading

PR Checklist

Overview

Adds a first auto-reply based on#5538 (comment).

@nx-cloud
Copy link

nx-cloudbot commentedSep 8, 2022
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitff2fa71. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 fromNxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@netlify
Copy link

netlifybot commentedSep 8, 2022
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitff2fa71
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/631e6ffb98dd3b0008dbf63b
😎 Deploy Previewhttps://deploy-preview-5618--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewSeptember 8, 2022 23:10
@bradzacher
Copy link
Member

bradzacher commentedSep 8, 2022
edited
Loading

My saved replies right now:

Extension Rule - Reject Due to Enhancement

I use this when someone requests an enhancement to an extension rule that would add or change the behaviour and cause us to break from the base rule.

Thanks for the issue!This is an extension rule. That means we take the base rule and extend it to support TS syntax or features.We don't break from the base rule to add new features unless they are specifically related to TS.In this instance - this request is not related to TS, thus we shall not implement it. If you'd like to see it, feel free to raise a request with the ESLint team.

Fix has been merged

I rarely use this now a days, but in the past I used this when people annoyingly asked "when will this be released?" on closed issues.

The fix has been merged to master, and will be released Monday, as per our [release schedule](https://github.com/typescript-eslint/typescript-eslint#versioning)If you need it sooner, please try the `canary` tag on NPM.

"Progress"

I use this when someone obnoxiously comments on a thread ("any updates?", "+1", etc). It's intentionally kinda strongly worded and more verbose.

With any issue in opened in this project - it either has a visible progress in the form of an attached PR, or it has no progress.We are a community run project. The **volunteer** maintainers spend most of their time triaging issues and reviewing PRs. This means that most issues *will not progress* unless a member of the community steps up and **champions** it.If this issue is important to you - consider being that champion.If not - please just subscribe to the issue and wait patiently.Commenting asking for status updates does not bump issue priority in any way and just serves to spam ***everyone*** subscribed to the issue.

"Progress - Nice"

I use this whenever someone is more polite in asking for updates. It's sadly used less than the other one.

We are a community run project. The **volunteer** maintainers spend most of their time triaging issues and reviewing PRs. This means that most issues *will not progress* unless a member of the community steps up and **champions** it.If this issue is important to you - consider being that champion.If not - please use the subscribe function and wait patiently for someone else to implement.

Review Queue

I used this when someone tags me

As per [our contributing guidelines](https://github.com/typescript-eslint/typescript-eslint/blob/master/CONTRIBUTING.md#addressing-feedback-and-beyond) this PR is in the queue of PRs to reviewed, and will be reviewed when we are able.This project is run by volunteer maintainers, so it might be a bit before we can find the time to get to it.

Use prettier

I use this when someone asks for a pure formatting rule. I think I've only used this once or twice.

We ***STRONGLY*** recommend you use automatic code formatters like [prettier](https://www.npmjs.com/package/prettier).Stylistic lint rules take a lot of effort to write, require ongoing maintenance to add more configuration as people want to fit their preferences, and are a large burden to maintain as new syntax is added.The configurability also leads to huge fanout [making tests huge, and awful to maintain](https://github.com/typescript-eslint/typescript-eslint/blob/b814e635c1f34139c89e0176727480935dd45cac/packages/eslint-plugin/tests/rules/type-annotation-spacing.test.ts).It's for these reasons that [eslint has frozen all stylistic lint rule options, and will not accept any new ones](https://eslint.org/blog/2020/05/changes-to-rules-policies).
JoshuaKGoldberg reacted with thumbs up emoji

@codecov
Copy link

codecovbot commentedSep 11, 2022
edited
Loading

Codecov Report

Merging#5618 (ff2fa71) intomain (77d76e2) willdecrease coverage by2.17%.
The diff coverage isn/a.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #5618      +/-   ##==========================================- Coverage   93.80%   91.63%   -2.18%==========================================  Files         292      134     -158       Lines       10009     1506    -8503       Branches     3010      226    -2784     ==========================================- Hits         9389     1380    -8009+ Misses        338       62     -276+ Partials      282       64     -218
FlagCoverage Δ
unittest91.63% <ø> (-2.18%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...lugin/src/rules/no-confusing-non-null-assertion.ts
...ackages/eslint-plugin/src/rules/no-for-in-array.ts
...nt-plugin/src/rules/switch-exhaustiveness-check.ts
...nt-plugin/src/rules/consistent-type-definitions.ts
packages/eslint-plugin/src/rules/indent.ts
...t-plugin/src/rules/class-literal-property-style.ts
packages/eslint-plugin/src/util/misc.ts
.../src/rules/sort-type-union-intersection-members.ts
...plugin/src/rules/naming-convention-utils/format.ts
...ages/eslint-plugin/src/rules/prefer-regexp-exec.ts
... and148 more

@bradzacherbradzacher merged commitbd4a7a6 intotypescript-eslint:mainSep 12, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the github-replies-start branchSeptember 12, 2022 11:11
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@Josh-CenaJosh-CenaJosh-Cena left review comments

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoshuaKGoldberg@bradzacher@Josh-Cena

[8]ページ先頭

©2009-2025 Movatter.jp