Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): uncollapse Rules sidebar by default again#5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedSep 8, 2022•
edited
Loading

PR Checklist

Overview

I'd missed (forgotten) in#5608 thatcreateCategory is also used for rules pages (https://typescript-eslint.io/rules & its children). We want them to be fully expanded too.

FYI@santoshyadavdev - my bad 😄

santoshyadavdev reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedSep 8, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit71c9a3d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedSep 8, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit71c9a3d
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6327ba9f5e7c220008a26a6c
😎 Deploy Previewhttps://deploy-preview-5616--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewSeptember 8, 2022 01:48
@santoshyadavdev
Copy link
Contributor

cool 😊

JoshuaKGoldberg reacted with laugh emoji

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

image

@bradzacherbradzacher changed the titlefix(website): uncollapse Rules sidebar by default againchore(website): uncollapse Rules sidebar by default againSep 19, 2022
@bradzacherbradzacher added the package: websiteIssues related to the @typescript-eslint website labelSep 19, 2022
@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)September 19, 2022 00:41
@codecov
Copy link

codecovbot commentedSep 19, 2022

Codecov Report

Merging#5616 (4de978d) intomain (75d78a4) willincrease coverage by0.62%.
The diff coverage isn/a.

❗ Current head4de978d differs from pull request most recent head71c9a3d. Consider uploading reports for the commit71c9a3d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##             main    #5616      +/-   ##==========================================+ Coverage   91.01%   91.63%   +0.62%==========================================  Files         365      134     -231       Lines       11962     1506   -10456       Branches     3483      226    -3257     ==========================================- Hits        10887     1380    -9507+ Misses        781       62     -719+ Partials      294       64     -230
FlagCoverage Δ
unittest91.63% <ø> (+0.62%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/scope-manager/src/scope/index.ts5.26% <0.00%> (-94.74%)⬇️
packages/scope-manager/src/definition/index.ts7.69% <0.00%> (-92.31%)⬇️
packages/scope-manager/src/index.ts45.45% <0.00%> (-27.28%)⬇️
packages/scope-manager/src/analyze.ts65.38% <0.00%> (ø)
packages/scope-manager/src/ScopeManager.ts79.74% <0.00%> (ø)
packages/scope-manager/src/scope/ForScope.ts100.00% <0.00%> (ø)
packages/scope-manager/src/scope/ScopeBase.ts91.46% <0.00%> (ø)
packages/scope-manager/src/scope/TypeScope.ts100.00% <0.00%> (ø)
packages/scope-manager/src/scope/WithScope.ts81.81% <0.00%> (ø)
packages/scope-manager/src/scope/BlockScope.ts100.00% <0.00%> (ø)
... and268 more

@JoshuaKGoldbergJoshuaKGoldberg merged commitef7a68c intotypescript-eslint:mainSep 19, 2022
@JoshuaKGoldbergJoshuaKGoldberg deleted the open-rules-menu branchSeptember 19, 2022 00:48
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
package: websiteIssues related to the @typescript-eslint website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Consider always expanding collapsible sidebar menus under docs/
3 participants
@JoshuaKGoldberg@santoshyadavdev@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp