Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
docs: [no-parameter-properties] fix broken link#5611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nx-cloudbot commentedSep 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the PR,@Josh-Cena! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
netlifybot commentedSep 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
codecovbot commentedSep 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #5611 +/- ##==========================================+ Coverage 93.80% 93.86% +0.06%========================================== Files 292 292 Lines 10009 10129 +120 Branches 3010 3054 +44 ==========================================+ Hits 9389 9508 +119- Misses 338 339 +1 Partials 282 282
Flags with carried forward coverage won't be shown.Click here to find out more.
|
| @@ -8,7 +8,7 @@ description: 'Disallow the use of parameter properties in class constructors.' | |||
| :::danger Deprecated | |||
| This rule has been deprecated in favour of the equivalent, better named [`parameter-properties`](./parameter-properties) rule. | |||
| This rule has been deprecated in favour of the equivalent, better named [`parameter-properties`](./parameter-properties.md) rule. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is already working on prod though. Why would we need to add the.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is not really working correctly, this generates link/rules/no-parameter-properties/parameter-properties instead of/rules/parameter-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Huh, very spooky, I do repro the 404 now. But I swear I didn't before...
Sorry—something's not working in me 😄 Let's see what the OP is actually about, then |
Resurrecting per#5603 (comment).@JoshuaKGoldberg Seems it doesn't work on all devices for some weird reason. Plus it's generally a better practice to use Markdown file references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Got it, thanks!
PR Checklist
Overview