typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(docs): always expanding collapsible sidebar menus under docs#5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromsantoshyadavdev:docs/always-expanding-collapsible-sidebar-menus-under-docs

Sep 7, 2022

Merged

feat(docs): always expanding collapsible sidebar menus under docs#5608

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromsantoshyadavdev:docs/always-expanding-collapsible-sidebar-menus-under-docs

Sep 7, 2022

Conversation

Copy link

Contributor

santoshyadavdev commentedSep 5, 2022•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesWebsite: Consider always expanding collapsible sidebar menus under docs/ #5554
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

feat(docs): always expanding collapsible sidebar menus under docs

f8bf93b

Copy link

nx-cloudbot commentedSep 5, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitfb0e962. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedSep 5, 2022

Thanks for the PR,@santoshyadavdev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedSep 5, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`fb0e962`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/631806010f43940008394749
😎 Deploy Preview	https://deploy-preview-5608--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JoshuaKGoldberg reviewed

Sep 5, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great so far! Just throwing an idea around ✨

packages/website/sidebars/sidebar.base.js Outdated

		@@ -41,6 +43,7 @@ module.exports = {
		{
		label: 'Architecture',
		type: 'category',
		collapsed: false,

Copy link

Member

JoshuaKGoldbergSep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What do you think about switching these to:

Suggested change

	collapsed:false,
	collapsible:false,

Reasoning: since there are so few menu options, I can't think of any reason why someone would want to collapse them. So the buttons to toggle collapse them are unnecessary UI.

Copy link

ContributorAuthor

santoshyadavdevSep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah makes sense, so no collapsible pane at all.

Let me try it.

Copy link

ContributorAuthor

santoshyadavdevSep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is how it looks after this

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Sep 5, 2022

feat(docs): always expanding collapsible sidebar menus under docs

4d00dee

JoshuaKGoldberg approved these changes

Sep 7, 2022

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 thanks@santoshyadavdev!

JoshuaKGoldbergenabled auto-merge (squash)

September 7, 2022 02:46

Merge branch 'main' into docs/always-expanding-collapsible-sidebar-me…

fb0e962

…nus-under-docs

Copy link

codecovbot commentedSep 7, 2022

Codecov Report

Merging#5608 (4d00dee) intomain (45e2912) willincrease coverage by0.03%.
The diff coverage isn/a.

❗ Current head4d00dee differs from pull request most recent headfb0e962. Consider uploading reports for the commitfb0e962 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #5608      +/-   ##==========================================+ Coverage   91.59%   91.63%   +0.03%==========================================  Files         369      134     -235       Lines       12391     1506   -10885       Branches     3613      226    -3387     ==========================================- Hits        11350     1380    -9970+ Misses        685       62     -623+ Partials      356       64     -292

Flag	Coverage Δ
unittest	`91.63% <ø> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...n/src/rules/no-non-null-asserted-optional-chain.ts
...ackages/eslint-plugin/src/rules/no-explicit-any.ts
...-plugin/src/rules/no-unnecessary-type-arguments.ts
...ges/eslint-plugin/src/rules/no-extraneous-class.ts
packages/eslint-plugin/src/rules/await-thenable.ts
packages/eslint-plugin/src/util/objectIterators.ts
...-plugin/src/rules/explicit-function-return-type.ts
...gin/src/rules/non-nullable-type-assertion-style.ts
...ges/eslint-plugin/src/rules/no-inferrable-types.ts
packages/type-utils/src/getTypeName.ts
... and225 more