Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(eslint-plugin): [prefer-optional-chain] support suggesting!foo || !foo.bar
as a valid match for the rule#5594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
JoshuaKGoldberg merged 11 commits intotypescript-eslint:mainfromomril1:feat/issue5245-negated-or-optional-chaining---fixedNov 7, 2022
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
11 commits Select commitHold shift + click to select a range
54f7470
feat/issue5245-negated-or-optional-chaining---fixed
c9e72c5
Not supported mixing with TSNonNullExpression
b628915
complex computed properties
a7a6d5b
Merge branch 'main' into feat/issue5245-negated-or-optional-chaining-…
585e197
Merge remote-tracking branch 'upstream/main' into feat/issue5245-nega…
befa01f
CR fix comment on unsupported cases and remove TODO comments
61751cd
Merge branch 'main' into feat/issue5245-negated-or-optional-chaining-…
4b33cab
Merge branch 'main' into feat/issue5245-negated-or-optional-chaining-…
b83107d
Merge branch 'main' into feat/issue5245-negated-or-optional-chaining-…
c2dc3bc
Merge remote-tracking branch 'upstream/main' into feat/issue5245-nega…
afdf2e7
CR: Remove unreachable uncovered check
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
12 changes: 11 additions & 1 deletionpackages/eslint-plugin/docs/rules/prefer-optional-chain.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.