typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(typescript-estree): don't double add decorators to a parameter property's parameter#5582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 2 commits intomainfrom5581-parameter-prop-decorators

Sep 1, 2022

Merged

fix(typescript-estree): don't double add decorators to a parameter property's parameter#5582

bradzacher merged 2 commits intomainfrom5581-parameter-prop-decorators

Sep 1, 2022

Conversation

Copy link

Member

bradzacher commentedAug 31, 2022

PR Checklist

Addresses an existing open issue:fixesBug: decorators get duplicated in AST for parameter properties #5581
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

Removes the unnecessary block that was added with the 4.8 support and adds a fixture for it

fix(typescript-estree): don't double add decorators to a parameter pr…

5d6ec7e

…operty's parameter

bradzacher added the bugSomething isn't working label

Aug 31, 2022

Copy link

nx-cloudbot commentedAug 31, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit716b1ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedAug 31, 2022

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedAug 31, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`716b1ba`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63104103fe54bc00083ae49c
😎 Deploy Preview	https://deploy-preview-5582--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

fix test

716b1ba

Copy link

codecovbot commentedSep 1, 2022•
edited
Loading

Codecov Report

Merging#5582 (716b1ba) intomain (f7c5deb) willdecrease coverage by0.03%.
The diff coverage isn/a.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #5582      +/-   ##==========================================- Coverage   91.62%   91.59%   -0.04%==========================================  Files         134      367     +233       Lines        1505    12383   +10878       Branches      226     3612    +3386     ==========================================+ Hits         1379    11342    +9963- Misses         62      685     +623- Partials       64      356     +292

Flag	Coverage Δ
unittest	`91.59% <ø> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	`97.89% <ø> (ø)`
...-estree/src/create-program/createDefaultProgram.ts	`77.27% <0.00%> (ø)`
packages/type-utils/src/propertyTypes.ts	`90.90% <0.00%> (ø)`
.../eslint-plugin/src/rules/restrict-plus-operands.ts	`88.67% <0.00%> (ø)`
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts	`100.00% <0.00%> (ø)`
...-internal/src/rules/no-typescript-estree-import.ts	`87.50% <0.00%> (ø)`
.../eslint-plugin/src/rules/method-signature-style.ts	`89.15% <0.00%> (ø)`
...ages/eslint-plugin/src/rules/no-empty-interface.ts	`100.00% <0.00%> (ø)`
...plugin/src/rules/no-redundant-type-constituents.ts	`93.89% <0.00%> (ø)`
packages/eslint-plugin-tslint/src/rules/config.ts	`97.29% <0.00%> (ø)`
... and224 more