Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(scope-manager): correct handling for class static blocks#5580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nx-cloudbot commentedAug 31, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the PR,@bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
netlifybot commentedAug 31, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
codecovbot commentedAug 31, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #5580 +/- ##==========================================- Coverage 91.60% 91.51% -0.09%========================================== Files 369 349 -20 Lines 12393 10945 -1448 Branches 3613 3222 -391 ==========================================- Hits 11352 10016 -1336+ Misses 685 602 -83+ Partials 356 327 -29
Flags with carried forward coverage won't be shown.Click here to find out more. |
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestSep 11, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.36.1` -> `5.36.2`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.36.1/5.36.2) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.36.1` -> `5.36.2`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.36.1/5.36.2) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary>### [`v5.36.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5362-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5361v5362-2022-09-05)[Compare Source](typescript-eslint/typescript-eslint@v5.36.1...v5.36.2)##### Bug Fixes- **eslint-plugin:** \[no-extra-parens] handle generic ts array type. ([#​5550](typescript-eslint/typescript-eslint#5550)) ([0d6a190](typescript-eslint/typescript-eslint@0d6a190))- **scope-manager:** correct handling for class static blocks ([#​5580](typescript-eslint/typescript-eslint#5580)) ([35bb8dd](typescript-eslint/typescript-eslint@35bb8dd))</details><details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary>### [`v5.36.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5362-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5361v5362-2022-09-05)[Compare Source](typescript-eslint/typescript-eslint@v5.36.1...v5.36.2)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTAuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE5MC4zIn0=-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1536Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestSep 27, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.36.2` -> `5.38.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.36.2/5.38.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.36.2` -> `5.38.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.36.2/5.38.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary>### [`v5.38.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5380-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5370v5380-2022-09-19)[Compare Source](typescript-eslint/typescript-eslint@v5.37.0...v5.38.0)**Note:** Version bump only for package [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)### [`v5.37.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5370-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5362v5370-2022-09-12)[Compare Source](typescript-eslint/typescript-eslint@v5.36.2...v5.37.0)##### Bug Fixes- **eslint-plugin:** \[strict-boolean-expressions] check all conditions in a logical operator chain ([#​5539](typescript-eslint/typescript-eslint#5539)) ([77d76e2](typescript-eslint/typescript-eslint@77d76e2))#### [5.36.2](typescript-eslint/typescript-eslint@v5.36.1...v5.36.2) (2022-09-05)##### Bug Fixes- **eslint-plugin:** \[no-extra-parens] handle generic ts array type. ([#​5550](typescript-eslint/typescript-eslint#5550)) ([0d6a190](typescript-eslint/typescript-eslint@0d6a190))- **scope-manager:** correct handling for class static blocks ([#​5580](typescript-eslint/typescript-eslint#5580)) ([35bb8dd](typescript-eslint/typescript-eslint@35bb8dd))#### [5.36.1](typescript-eslint/typescript-eslint@v5.36.0...v5.36.1) (2022-08-30)**Note:** Version bump only for package [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)</details><details><summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary>### [`v5.38.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5380-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5370v5380-2022-09-19)[Compare Source](typescript-eslint/typescript-eslint@v5.37.0...v5.38.0)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)### [`v5.37.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5370-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5362v5370-2022-09-12)[Compare Source](typescript-eslint/typescript-eslint@v5.36.2...v5.37.0)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.36.2](typescript-eslint/typescript-eslint@v5.36.1...v5.36.2) (2022-09-05)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.36.1](typescript-eslint/typescript-eslint@v5.36.0...v5.36.1) (2022-08-30)**Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1545Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
I wasn't paying anywhere near enough attention when reviewing#5489.
That PR did not actually properly implement scope analysis.
It created a scope but never closed it - meaning if you had a static block it'd leave a dangling scope which breaks things.
Also it never actually visited the static block's children.
This PR closes off the scope and visits the children, fixing the problem