There's a lot of unrelated changes in here - it took me a while to really nail down exactly what the problem was. I spent a chunk of time just figuring out how everything worked.

I still don't knowwhy it occurred, but for some reason when we upgraded to TS4.8 the website-eslint build started including a dependency that requiredos andstream (nodejs modules). Because rollup can't bundle nodejs modules - it assumed they'd be provided later, which they weren't - leading to unresolved imports that (I think) monaco attempted to resolve by loading a script from the server.

Result of testing with this PR locally:

bradzacher added the bugSomething isn't working label

Aug 30, 2022

Copy link

nx-cloudbot commentedAug 30, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit8026e77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedAug 30, 2022

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedAug 30, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`8026e77`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/630eefd05dcd9100087cc962
😎 Deploy Preview	https://deploy-preview-5575--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

bradzacher commented

Aug 30, 2022

View reviewed changes

packages/website-eslint/rollupConfig.ts OutdatedShow resolvedHide resolved

bradzacher commented

Aug 30, 2022

View reviewed changes

packages/website-eslint/rollupConfig.ts OutdatedShow resolvedHide resolved

Copy link

codecovbot commentedAug 30, 2022•
edited
Loading

Codecov Report

Merging#5575 (8026e77) intomain (27b24e3) willincrease coverage by0.02%.
The diff coverage isn/a.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #5575      +/-   ##==========================================+ Coverage   91.60%   91.62%   +0.02%==========================================  Files         369      134     -235       Lines       12393     1505   -10888       Branches     3613      226    -3387     ==========================================- Hits        11352     1379    -9973+ Misses        685       62     -623+ Partials      356       64     -292

Flag	Coverage Δ
unittest	`91.62% <ø> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...ges/eslint-plugin/src/rules/no-extraneous-class.ts
packages/eslint-plugin/src/rules/comma-dangle.ts
packages/eslint-plugin/src/rules/unbound-method.ts
packages/utils/src/ast-utils/index.ts
packages/eslint-plugin/src/rules/await-thenable.ts
...nt-plugin/src/rules/switch-exhaustiveness-check.ts
packages/utils/src/ast-utils/eslint-utils/index.ts
...ript-estree/src/create-program/createSourceFile.ts
packages/eslint-plugin/src/rules/array-type.ts
...plugin/src/rules/naming-convention-utils/shared.ts
... and225 more