fix(typescript-estree): fix decorator regression for pre TS4.8#5574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 3 commits intomainfrom5571-decorator-regression

Aug 30, 2022

Merged

fix(typescript-estree): fix decorator regression for pre TS4.8#5574

bradzacher merged 3 commits intomainfrom5571-decorator-regression

Aug 30, 2022

Conversation

Copy link

Member

bradzacher commentedAug 30, 2022

PR Checklist

Addresses an existing open issue:fixesBug: [no-unused-vars] 'Component' is defined but never used #5571
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

#5573 will add CI tests for this, so for now you'll have to trust me that this fixes things

fix(typescript-estree): fix decorator regression for pre TS4.8

c1a5aa5

bradzacher added the bugSomething isn't working label

Aug 30, 2022

Copy link

Contributor

typescript-eslintbot commentedAug 30, 2022

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

nx-cloudbot commentedAug 30, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3e43f2e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

Copy link

netlifybot commentedAug 30, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`3e43f2e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/630de26fb8b87b00090b9764
😎 Deploy Preview	https://deploy-preview-5574--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.