typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

test: add regression testing against old TS and ESLint versions in the CI#5573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

bradzacher wants to merge17 commits intomainfromversion-regression-testing

Closed

test: add regression testing against old TS and ESLint versions in the CI#5573

bradzacher wants to merge17 commits intomainfromversion-regression-testing

Conversation

Copy link

Member

bradzacher commentedAug 30, 2022

PR Checklist

Addresses an existing open issue:fixesAdd automated regression testing against old TS versions #1752
That issue was marked asaccepting prs
Steps inCONTRIBUTING.md were taken

Overview

#5571 shows that we really need to be testing against old TS versions.
This PR adds testing to the CI so that we can at least catch it.

bradzacher added the testsanything to do with testing label

Aug 30, 2022

Copy link

nx-cloudbot commentedAug 30, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit72527e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`Node - nx test utils --coverage=false`
`Node - nx test utils --coverage=false`
`Node - nx test scope-manager --coverage=false`
`Node - nx test scope-manager --coverage=false`

✅ Successfully ran 64 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

typescript-eslintbot commentedAug 30, 2022

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

netlifybot commentedAug 30, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`72527e5`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63f3e5e66415b00008a2a581
😎 Deploy Preview	https://deploy-preview-5573--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

bradzacher force-pushed theversion-regression-testing branch 2 times, most recently fromee3b014 to25fb41dCompare

August 30, 2022 09:17

bradzacher mentioned this pull request

Aug 30, 2022

fix(typescript-estree): fix decorator regression for pre TS4.8#5574

Merged

3 tasks

Copy link

MemberAuthor

bradzacher commentedAug 31, 2022

The actions are all setup and working just fine, but there is two problems to solve.

Parsing new features in old versions.
- Old TS parsers will crash on new syntax which will fail our snapshot tests in the scope analyser and parser, and will fail ESLint rule tests.
Extension rules behave differently on old ESLint versions.
- Some of our extension rules are built directly on top of the core rule's code - this means that their behaviour is dependent on the core rule's behaviour, which means the tests (which are written against the latest version) can break.

We need a way to: