Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: Fix links to getting started in README.md#5546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

sivagorrepati
Copy link
Contributor

@sivagorrepatisivagorrepati commentedAug 26, 2022•
edited
Loading

PR Checklist

Overview

Update readme files to new getting started page

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sivaprasad!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedAug 26, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9e00abf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedAug 26, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit9e00abf
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6308103e29a3d20008bb94bd
😎 Deploy Previewhttps://deploy-preview-5546--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@sivagorrepatisivagorrepati changed the titledocs: Fix links to getting starteddocs: Fix links to getting started in README.mdAug 26, 2022
@codecov
Copy link

codecovbot commentedAug 26, 2022•
edited
Loading

Codecov Report

Merging#5546 (9e00abf) intomain (69e4cb9) willincrease coverage by0.17%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #5546      +/-   ##==========================================+ Coverage   91.57%   91.75%   +0.17%==========================================  Files         132      366     +234       Lines        1496    12380   +10884       Branches      226     3611    +3385     ==========================================+ Hits         1370    11359    +9989- Misses         62      669     +607- Partials       64      352     +288
FlagCoverage Δ
unittest91.75% <ø> (+0.17%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...t-plugin/src/rules/no-confusing-void-expression.ts98.85% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/space-infix-ops.ts100.00% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts98.35% <0.00%> (ø)
...lugin/src/rules/no-confusing-non-null-assertion.ts82.60% <0.00%> (ø)
packages/utils/src/eslint-utils/deepMerge.ts89.47% <0.00%> (ø)
...int-plugin/src/rules/consistent-type-assertions.ts88.88% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-for-in-array.ts100.00% <0.00%> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts90.36% <0.00%> (ø)
packages/eslint-plugin/src/rules/quotes.ts88.88% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-this-alias.ts100.00% <0.00%> (ø)
... and224 more

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Funny, wejust were looking at the Netlify analytics and saw these as relatively higher frequency 404s. Thanks for the spot + fix@sivaprasad! 😄

@JoshuaKGoldbergJoshuaKGoldberg merged commit39829c0 intotypescript-eslint:mainAug 26, 2022
@sivagorrepatisivagorrepati deleted the fixGettingStartedLinks branchAugust 26, 2022 17:03
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Links to getting started pages are broken
2 participants
@sivagorrepati@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp