Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [strict-boolean-expressions] check all conditions in a logical operator chain#5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

phaux
Copy link
Contributor

PR Checklist

Overview

At first it was a one line change but then I also refactored the recursive code to make it more easy to reason about hopefully.

Before:

checked && skipped && skipped && skipped;

After:

checked && checked && checked && skipped;

Same for||

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@phaux!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@nx-cloud
Copy link

nx-cloudbot commentedAug 24, 2022•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5ee55fe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

@netlify
Copy link

netlifybot commentedAug 24, 2022•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5ee55fe
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6319f297d9e95f00084fbc69
😎 Deploy Previewhttps://deploy-preview-5539--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@codecov
Copy link

codecovbot commentedAug 24, 2022•
edited
Loading

Codecov Report

Merging#5539 (5ee55fe) intomain (8176fb1) willincrease coverage by2.17%.
The diff coverage is100.00%.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #5539      +/-   ##==========================================+ Coverage   91.63%   93.80%   +2.17%==========================================  Files         134      292     +158       Lines        1506    10009    +8503       Branches      226     3010    +2784     ==========================================+ Hits         1380     9389    +8009- Misses         62      338     +276- Partials       64      282     +218
FlagCoverage Δ
unittest93.80% <100.00%> (+2.17%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts98.83% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts100.00% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts100.00% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/shared.ts100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts75.84% <0.00%> (ø)
packages/eslint-plugin/src/util/isNullLiteral.ts100.00% <0.00%> (ø)
...eslint-plugin/src/rules/no-parameter-properties.ts94.11% <0.00%> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts79.48% <0.00%> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts100.00% <0.00%> (ø)
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts75.00% <0.00%> (ø)
... and149 more

@phauxphauxforce-pushed thestrict-bool-expr-fix-logical-chain branch fromdf8504e tofd8ffbbCompareAugust 24, 2022 20:42
@bradzacherbradzacher changed the titlefix(eslint-plugin): [strict-bool-expr] check all conditions in a logical operator chainfix(eslint-plugin): [strict-boolean-expressions] check all conditions in a logical operator chainAug 25, 2022
@bradzacherbradzacher added the bugSomething isn't working labelAug 25, 2022
@@ -304,6 +304,67 @@ if (y) {
],
},

// a chain of logical operators should check every operand except the last one in a chain

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you add some passing (valid) test cases too, please?

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks great, +1 to the refactor!

Just requesting changes on a little bit more testing please.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelSep 4, 2022
@phauxphauxforce-pushed thestrict-bool-expr-fix-logical-chain branch from72cc5c5 to5ee55feCompareSeptember 8, 2022 13:48
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯, thanks@phaux!

@JoshuaKGoldbergJoshuaKGoldbergenabled auto-merge (squash)September 8, 2022 23:13
@JoshuaKGoldbergJoshuaKGoldberg merged commit77d76e2 intotypescript-eslint:mainSep 8, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull requestSep 27, 2022
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.36.2` -> `5.38.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.36.2/5.38.0) || [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.36.2` -> `5.38.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.36.2/5.38.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v5.38.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5380-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5370v5380-2022-09-19)[Compare Source](typescript-eslint/typescript-eslint@v5.37.0...v5.38.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)### [`v5.37.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5370-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5362v5370-2022-09-12)[Compare Source](typescript-eslint/typescript-eslint@v5.36.2...v5.37.0)##### Bug Fixes-   **eslint-plugin:** \[strict-boolean-expressions] check all conditions in a logical operator chain ([#&#8203;5539](typescript-eslint/typescript-eslint#5539)) ([77d76e2](typescript-eslint/typescript-eslint@77d76e2))#### [5.36.2](typescript-eslint/typescript-eslint@v5.36.1...v5.36.2) (2022-09-05)##### Bug Fixes-   **eslint-plugin:** \[no-extra-parens] handle generic ts array type. ([#&#8203;5550](typescript-eslint/typescript-eslint#5550)) ([0d6a190](typescript-eslint/typescript-eslint@0d6a190))-   **scope-manager:** correct handling for class static blocks ([#&#8203;5580](typescript-eslint/typescript-eslint#5580)) ([35bb8dd](typescript-eslint/typescript-eslint@35bb8dd))#### [5.36.1](typescript-eslint/typescript-eslint@v5.36.0...v5.36.1) (2022-08-30)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v5.38.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5380-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5370v5380-2022-09-19)[Compare Source](typescript-eslint/typescript-eslint@v5.37.0...v5.38.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)### [`v5.37.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5370-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5362v5370-2022-09-12)[Compare Source](typescript-eslint/typescript-eslint@v5.36.2...v5.37.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.36.2](typescript-eslint/typescript-eslint@v5.36.1...v5.36.2) (2022-09-05)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)#### [5.36.1](typescript-eslint/typescript-eslint@v5.36.0...v5.36.1) (2022-08-30)**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->Co-authored-by: cabr2-bot <cabr2.help@gmail.com>Reviewed-on:https://codeberg.org/Calciumdibromid/CaBr2/pulls/1545Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another partybugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [strict-boolean-expressions] Only the first operand in a chain of&& is checked
3 participants
@phaux@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp